Package: lastfm
Version: 1:1.5.1.31879.dfsg-1
Severity: serious
Tags: patch
Justification: no longer builds from source
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu jaunty ubuntu-patch

Hi,

This are the errors that I get when rebuilding lastfm with qt45:
.../build/ui_playcontrols.h:34: error: ISO C++ forbids declaration of 
'VolumeSlider' with no type
.../build/ui_playcontrols.h:34: error: expected ';' before '*' token
.../build/ui_playcontrols.h: In member function 'void 
Ui_PlayControls::setupUi(QWidget*)':
.../build/ui_playcontrols.h:62: error: 'volume' was not declared in this scope
.../build/ui_playcontrols.h:62: error: expected type-specifier before 
'VolumeSlider'
.../build/ui_playcontrols.h:62: error: expected `;' before 'VolumeSlider'

This is because the header VolumeSlider.h is generated as 
phonon/Phonon::VolumeSlider instead of VolumeSlider.h. Adding a point before 
header name fix that.

*** /tmp/tmprCxiEe
In Ubuntu, we've applied the attached patch to achieve the following:

  * debian/patches/qt45.diff: fix the volumeslider header name to avoid qt45
    to generate phonon/Phonon::VolumeSlider as header name (LP: #337862)

We thought you might be interested in doing the same. 


-- System Information:
Debian Release: 5.0
  APT prefers jaunty-updates
  APT policy: (500, 'jaunty-updates'), (500, 'jaunty-security'), (500, 'jaunty')
Architecture: i386 (x86_64)

Kernel: Linux 2.6.27-11-generic (SMP w/2 CPU cores)
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)
Shell: /bin/sh linked to /bin/dash
diff -u lastfm-1.5.1.31879.dfsg/debian/patches/series lastfm-1.5.1.31879.dfsg/debian/patches/series
--- lastfm-1.5.1.31879.dfsg/debian/patches/series
+++ lastfm-1.5.1.31879.dfsg/debian/patches/series
@@ -15,0 +16 @@
+qt45.diff
only in patch2:
unchanged:
--- lastfm-1.5.1.31879.dfsg.orig/debian/patches/qt45.diff
+++ lastfm-1.5.1.31879.dfsg/debian/patches/qt45.diff
@@ -0,0 +1,12 @@
+--- lastfm-1.5.1.31879.dfsg.orig/src/playcontrols.ui
++++ lastfm-1.5.1.31879.dfsg/src/playcontrols.ui
+@@ -146,7 +146,7 @@
+   <customwidget>
+    <class>VolumeSlider</class>
+    <extends>QFrame</extends>
+-   <header>volumeslider.h</header>
++   <header>./volumeslider.h</header>
+    <container>1</container>
+   </customwidget>
+  </customwidgets>
+

Reply via email to