Package: hugs Version: 98.200503.08-1 Severity: normal Tags: patch -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Hi, I was looking at the packaging of Hugs and noticed a couple of things. First of all the package is missing build depenencies on xlibmesa-gl-dev freeglut3-dev and libxt-dev. Secondly I found a small mistake in the handling of DEB_BUILD_OPTIONS. If the DEB_BUILD_OPTIONS environment variable DOES NOT CONTAIN noopt hugs is build WITHOUT optimization and if it DOES CONTAIN noopt it is build WITH optimization. Lastly I saw that install_exec variable containing the install command for installing executables always strips (-s) the binary it installs, regardless whether DEB_BUILD_OPTIONS contains nostrip or not. Note that this isn't a big problem because install_exec isn't used anywhere, but I fixed it anyway :) I have attached a patch which fixes all these problems. Greetings, Arjan Oosting - -- System Information: Debian Release: testing/unstable APT prefers testing APT policy: (990, 'testing'), (500, 'testing-proposed-updates'), (500, 'unstable'), (102, 'experimental') Architecture: i386 (i686) Shell: /bin/sh linked to /bin/bash Kernel: Linux 2.6.11-2-stardust Locale: [EMAIL PROTECTED], [EMAIL PROTECTED] (charmap=UTF-8) Versions of packages hugs depends on: ii libc6 2.3.2.ds1-22 GNU C Library: Shared libraries an ii libncurses5 5.4-8 Shared libraries for terminal hand ii libreadline4 4.3-15 GNU readline and history libraries hugs recommends no packages. - -- no debconf information -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.1 (GNU/Linux) iD8DBQFCwyWNUALvsZYuOJARAn+/AJ48koHmzlZUYVYjB5r3c0nAtCu0SgCeLr08 IefodOmUFV76XYGuobiYA8g= =TdEo -----END PGP SIGNATURE-----
diff -Naur orig/hugs98-98.200503.08/debian/changelog hugs98-98.200503.08/debian/changelog --- orig/hugs98-98.200503.08/debian/changelog 2005-06-30 00:34:10.000000000 +0200 +++ hugs98-98.200503.08/debian/changelog 2005-06-30 00:11:40.000000000 +0200 @@ -1,3 +1,15 @@ +hugs98 (98.200503.08-1.1) unstable; urgency=low + + * Non-maintainer upload. + * Fix debian/rules to use --enable-debug when DEB_BUILD_OPTIONS + contains noopt not the other way around. + * Fix debian/rules to stop stripping binaries when DEB_BUILD_OPTIONS + contains nostrip. + * Added missing build dependencies on xlibmesa-gl-dev and freeglut3- + dev and libxt-dev. + + -- Arjan Oosting <[EMAIL PROTECTED]> Wed, 29 Jun 2005 23:27:54 +0200 + hugs98 (98.200503.08-1) unstable; urgency=low * New upstream release diff -Naur orig/hugs98-98.200503.08/debian/control hugs98-98.200503.08/debian/control --- orig/hugs98-98.200503.08/debian/control 2005-06-30 00:34:10.000000000 +0200 +++ hugs98-98.200503.08/debian/control 2005-06-30 00:11:21.000000000 +0200 @@ -3,7 +3,7 @@ Priority: optional Maintainer: Isaac Jones <[EMAIL PROTECTED]> Standards-Version: 3.6.1 -Build-Depends: libncurses5-dev, libreadline4-dev (>= 4.1), autotools-dev +Build-Depends: libncurses5-dev, libreadline4-dev (>= 4.1), autotools-dev, xlibmesa-gl-dev, freeglut3-dev, libxt-dev Build-Conflicts: byacc Package: hugs diff -Naur orig/hugs98-98.200503.08/debian/rules hugs98-98.200503.08/debian/rules --- orig/hugs98-98.200503.08/debian/rules 2005-06-30 00:34:10.000000000 +0200 +++ hugs98-98.200503.08/debian/rules 2005-06-29 23:54:54.000000000 +0200 @@ -8,7 +8,7 @@ # Modified for Hugs-Nov2002-Nov2003 by Isaac Jones <[EMAIL PROTECTED]> install := install -o root -g root -install_exec := $(install) -m 755 -s +install_exec := $(install) -m 755 install_dir := $(install) -m 755 -d install_nonex = $(install) -m 644 install_script := $(install) -m 755 @@ -17,9 +17,13 @@ GZIP := gzip -9v DEBUG_OPT= -ifeq (,$(findstring noopt,$(DEB_BUILD_OPTIONS))) +ifneq (,$(findstring noopt,$(DEB_BUILD_OPTIONS))) DEBUG_OPT = --enable-debug endif +ifeq (,$(findstring nostrip,$(DEB_BUILD_OPTIONS))) + install_exec += -s +endif + package = hugs tmpdir := $(shell pwd)/debian/tmp