Hi Tobi, On Mon, Apr 13, 2009 at 08:00:50PM +0200, Tobias Oetiker wrote: > Today Sebastian Harl wrote: > > On Thu, Apr 09, 2009 at 05:47:58PM +0200, Tobias Oetiker wrote: > > > Yesterday Sebastian Harl wrote: > > > > On Wed, Apr 08, 2009 at 07:32:38AM +0200, Tobias Oetiker wrote: > > > > > Otherwhise the solution is simple, update the docs and mention > > > > > that it does NOT work and if someone is so minded, update RRDp to > > > > > support graphv > > > > > > > > Well, that's basically what I proposed initially - I would have gone for > > > > reporting an error if "graph -" is used in RRDp::cmd though. When I was > > > > asking for someone to provide a patch, I had support for graphv in mind. > > > > Sorry, if that wasn't clear in the first place. Anyway, those two > > > > changes would be a perfectly valid solution for this problem imho. > > > > > > well for the moment the check for a call to graph - sounds like a > > > simple enough thing todo ... will create a patch and send it your > > > way ... > > > > Well, that's trivial ... ;-) I've attached a patch to take care of that. > > Anyway, you've talked about "enhancing RRDp accordingly" - what did you > > have in mind then? None of the other commands is handled specifically > > ... > > well there is a special response protocol shared by rrd_info > rrd_graphv and rrd_updatev ... this could be handled by RRDp.pm
Sounds good to me. I'd image that something like returning a hash value that stores the returned key-value pairs would make sense. Did you have something else in mind? > it would not be all that hard to implement, do you have any > indication (apart from this) bug who is using RRDp.pm ? Sorry, I have no idea ... > > Also, I noticed that graphv isn't documented yet. Having RRDp point to > > some undocumented feature is not very nice imho. Would you mind > > providing a manpage for that? > > the graphv command is documented in the rrdgraph manual page > (similar to updatev) ... Oops, I missed that. Cheers, Sebastian -- Sebastian "tokkee" Harl +++ GnuPG-ID: 0x8501C7FC +++ http://tokkee.org/ Those who would give up Essential Liberty to purchase a little Temporary Safety, deserve neither Liberty nor Safety. -- Benjamin Franklin
signature.asc
Description: Digital signature
