tags 515259 + wontfix thanks Hi Timo--
Thanks for your suggestion about shipping a compiled version of
ivorbisfile_example.c. I think that's probably not a good idea, as
inspection of the source indicates a number of cases where it's too
brittle for general-purpose use. For example, toward the end of the file:
[...]
} else if (ret < 0) {
/* error in the stream. Not a problem, just reporting it in
case we (the app) cares. In this case, we don't. */
} else {
/* we don't bother dealing with sample rate changes, etc, but
you'll have to*/
fwrite(pcmout,1,ret,stdout);
}
[...]
I worry that shipping ivorbisfile_example as a compiled binary would
encourage people to use it, despite the fact that it quietly discards
errors, and doesn't now how to deal with things like sampling rate
changes, etc. Furthermore, it wouldn't be clear to most folks how to
use it to actually play music (as it just emits a PCM stream on stdout,
rather than feeding the stream into an audio interface of some sort).
However, the file is BSD-licensed. If you wanted to build a small,
simple tool that *does* handle those things reasonably, you could base
it off of this file and distribute it separately with no problem.
Alternately, if you wanted to submit changes to this file to make it
something that would be conceivably supportable, i'd be happy to
advocate for those changes with upstream as well.
But as it stands, i think shipping a compiled example probably isn't a
good idea, so i'm tagging this wontfix.
Regards,
--dkg
signature.asc
Description: OpenPGP digital signature
