On Wed, 2009-03-25 at 21:20 +0100, Mike Hommey wrote: > On Wed, Mar 25, 2009 at 09:14:56AM +0100, Julien Cristau wrote: > > On Wed, 2009-03-25 at 07:47 +0100, Julien Cristau wrote: > > > I've spent some time looking at this, and I'm a bit worried about > > > PKIX_PL_Object_Alloc. Specifically, sizeof(PKIX_PL_Object) seems to be > > > 28 on 32bit, and __alignof__(PKIX_PL_Object) is 4. PKIX_PL_Object_Alloc > > > goes to allocate some space for one PKIX_PL_Object + the size it was > > > asked for, and then goes and returns object + 1. Thus, if > > > PKIX_PL_Malloc gives it a 8 byte aligned pointer, PKIX_PL_Object_Alloc > > > will return an unaligned address to its caller. PKIX_PL_OcspResponse's > > > size is 56, and it has to be 8 byte aligned on sparc, so it's possible > > > this is the problem here. > > > > It'd be nice if someone could try the attached patch on sparc and see if > > they can reproduce the browser crash. > > Wouldn't it be simpler to make PKIX_PL_Object 32 bytes ? > That would work too (hopefully not increasing its 40 bytes on 64bit). Not sure which one is simpler.
Cheers, Julien -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
