On Sun, Mar 22, 2009 at 01:54:22AM +0100, Thibaut VARENE wrote:
> I've been noticing for a while that running "make install" in my kernel source
> tree would consistently replace the symlinks in /boot ("vmlinuz", "System.map"
> & co) with plain files, instead of updating the symlinks as one would normaly
> expect.
>
> Turns out that there seems to be a bogus test in installkernel:46
> This line:
> [ "$(readlink -f ${dir}/${1})" = "${dir}/${1}-${ver}" ]
> looks wrong. It's an assignment, where a test for (in)equality was presumably
> intended.
No, in POSIX sh that is not an assignment.
> But then, if the test was meant to check whether the current link points to a
> different file than the one being installed, everything goes fine provided
> that
> we are indeed not reinstalling the same kernel version. Otherwise, the
> inequality test will fail and we'll fall back to the else clause of the if
> statement, leading to plain file creation again. That is because on line 45,
> the two tests must be validated to work.
>
> I suggest either plain removing the additional check on line 46 or nesting it.
Manoj?
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
