Let me offer a bit of history on this problem.

In 1.13-3, A patch was added which fixed quoting for uk.finance.yahoo.com.

There are two lines of interest in Base.pm which in 1.13-2 must have looked like this.

@FIELDS = qw/symbol name last date time net p_change volume bid ask
              close open day_range year_range eps pe div_date div div_yield
             cap ex_div avg_vol currency/;

@FIELD_ENCODING = qw/s n l1 d1 t1 c1 p2 v b a p o m w e r r1 d y j1 q a2 c4/;


The patch for 1.13-3 changes the order of date and time in @FIELDS and leaves @FIELD_ENCODING alone. One would have thought that this misalignment would not work at all, but in fact it actually made things work for uk.finance.yahoo.com.

It did however break things for finance.yahoo.com, and that is when I got involved with issue 490395.
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=490395

My first thought was to change @FIELDS back to the way it was, and that did indeed fix my problem with finance, but broke uk again. After a little digging I figured out what was going on. I linked to that discussion in the issue, but unfortunately the linked information went private, so I can't see it any more.

Essentially one of d1 or t1 is actually ignored on uk, and the other stands for time and date in that order. That's why 1.13-3 worked on uk. For finance however, d1 means date and t1 means time.

In the patch that was used to make 1.13-4, I switch the order in @FIELD_ENCODING to be t1 d1 to match the new order in @FIELDS. This fixed finance because now the fields and encodings matched. And it still worked on uk because "t1 d1" together still means "time date".

Now the new upstream release has arrived, 1.15-1. This again breaks finance.yahoo.com for me. This again puts date before time in @FIELDS but leave my patch which puts t1 d1 into @FIELD_ENCODING.

So to fix things for me, I have applied the following patch.
------------------------------------------------------------------------- Base.pm.20090321 2009-03-21 12:33:19.000000000 -0500
+++ Base.pm     2009-03-21 12:33:46.000000000 -0500
@@ -56,7 +56,7 @@
 # in the URL.  These are recorded below, along with their corresponding
 # field names.

-...@fields = qw/symbol name last date time net p_change volume bid ask
+...@fields = qw/symbol name last time date net p_change volume bid ask
              close open day_range year_range eps pe div_date div div_yield
             cap ex_div avg_vol currency/;

----------------------------------------------------------------------

At the moment, I can't remember how to test this, but I thought it would be helpful to give some perspective about how we got here.

-John Marter



--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to