Package: nvclock
Version: 0.8b4-1
Severity: minor
Tags: patch
User: ubuntu-de...@lists.ubuntu.com
Usertags: ubuntu-patch origin-ubuntu jaunty

Hi Randall,

Please find attached a patch to nvclock that fixes a number of lintian
warnings/errors in the package.  I've confirmed that all of these are
correct fixes.

Thanks,
-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                    http://www.debian.org/
slanga...@ubuntu.com                                     vor...@debian.org
diff -Nru nvclock-0.8b4/debian/changelog nvclock-0.8b4/debian/changelog
--- nvclock-0.8b4/debian/changelog	2009-03-20 23:58:42.000000000 +0000
+++ nvclock-0.8b4/debian/changelog	2009-03-20 23:58:42.000000000 +0000
@@ -1,3 +1,22 @@
+nvclock (0.8b4-1.1) unstable; urgency=low
+
+  * lintian fixes:
+    - debian/copyright: add an actual copyright notice.
+    - debian/copyright: copy the GPLv2+ license text.
+    - remove empty debian/nvclock.postinst - minor, but makes dpkg less
+      efficient about package states
+    - debian/control: GTK -> GTK+
+    - debian/control: add ${misc:Depends} to the deps of all packages
+    - debian/nvclock-{qt,gtk}.menu: quote the "needs" and "section"
+      strings, and use the menu section that the Debian menu policy
+      explicitly says this package should be using (System/Hardware) :-)
+    - debian/rules, debian/compat: set the debhelper compat level in the
+      authoritative place.
+    - debian/rules: don't ignore errors from 'make clean'.
+    - debian/control: Standards-Version to 3.8.0
+
+ -- Steve Langasek <vor...@debian.org>  Fri, 20 Mar 2009 22:58:10 +0000
+
 nvclock (0.8b4-1) unstable; urgency=low
 
   * New upstream release. (closes: #511979, #433375, #360097, #414236)
diff -Nru nvclock-0.8b4/debian/compat nvclock-0.8b4/debian/compat
--- nvclock-0.8b4/debian/compat	1970-01-01 00:00:00.000000000 +0000
+++ nvclock-0.8b4/debian/compat	2009-03-20 23:58:42.000000000 +0000
@@ -0,0 +1 @@
+5
diff -Nru nvclock-0.8b4/debian/control nvclock-0.8b4/debian/control
--- nvclock-0.8b4/debian/control	2009-03-20 23:58:42.000000000 +0000
+++ nvclock-0.8b4/debian/control	2009-03-20 23:58:42.000000000 +0000
@@ -4,14 +4,14 @@
 Maintainer: Debian NVIDIA Maintainers <pkg-nvidia-de...@lists.alioth.debian.org>
 Uploaders: Randall Donald <rdon...@debian.org>
 Build-Depends: debhelper (>> 5.0.0), libqt3-mt-dev (>= 3.1.0), libgtk2.0-dev, libglib2.0-dev
-Standards-Version: 3.6.2
+Standards-Version: 3.8.0
 
 Package: nvclock
 Architecture: any
-Depends: ${shlibs:Depends}
+Depends: ${shlibs:Depends}, ${misc:Depends}
 Suggests: nvidia-glx
 Description: Allows you to overclock your nVidia card under GNU/Linux
- This program allows you to overclock your nVidia chip based video card. 
+ This program allows you to overclock your nVidia chip based video card.
  The official binary nVidia drivers are required for accesses other than
  by root.
  .
@@ -19,18 +19,18 @@
 
 Package: nvclock-gtk
 Architecture: any
-Depends: ${shlibs:Depends}
+Depends: ${shlibs:Depends}, ${misc:Depends}
 Suggests: nvidia-glx
 Description: Allows you to overclock your nVidia card under GNU/Linux
  nvclock allows you to overclock your nVidia chip based video card.
  The official binary nVidia drivers are required for accesses other than
  by root.
  .
- This is the GTK version.
+ This is the GTK+ version.
 
 Package: nvclock-qt
 Architecture: any
-Depends: ${shlibs:Depends}
+Depends: ${shlibs:Depends}, ${misc:Depends}
 Suggests: nvidia-glx
 Description: Allows you to overclock your nVidia card under GNU/Linux
  nvclock allows you to overclock your nVidia chip based video card.
diff -Nru nvclock-0.8b4/debian/copyright nvclock-0.8b4/debian/copyright
--- nvclock-0.8b4/debian/copyright	2009-03-20 23:58:42.000000000 +0000
+++ nvclock-0.8b4/debian/copyright	2009-03-20 23:58:42.000000000 +0000
@@ -9,6 +9,12 @@
 	Christian Zander <phoe...@minion.de>
 	Jan Prokop <jpro...@ibl.nospam.sk>
 
-You are free to distribute this software under the terms of the GNU General
-Public License.  On Debian systems, the complete text of the GNU General Public
+Copyright 2001-2008 Roderick Colenbrander et al.
+
+This program is free software; you can redistribute it and/or modify it
+under the terms of the GNU General Public License as published by the
+Free Software Foundation; either version 2 of the License, or (at your
+option) any later version.
+
+On Debian systems, the complete text of the GNU General Public
 License can be found in /usr/share/common-licenses/GPL file.
diff -Nru nvclock-0.8b4/debian/nvclock-gtk.menu nvclock-0.8b4/debian/nvclock-gtk.menu
--- nvclock-0.8b4/debian/nvclock-gtk.menu	2009-03-20 23:58:42.000000000 +0000
+++ nvclock-0.8b4/debian/nvclock-gtk.menu	2009-03-20 23:58:42.000000000 +0000
@@ -1,6 +1,6 @@
 ?package(nvclock-gtk):\
- needs=X11\
- section=Apps/System\
+ needs="X11"\
+ section="Applications/System/Hardware"\
  longtitle="nvclock: overclock your nVidia card (GTK GUI)"\
  title="Nvclock for GTK+"\
  command="/usr/bin/nvclock_gtk"
diff -Nru nvclock-0.8b4/debian/nvclock-qt.menu nvclock-0.8b4/debian/nvclock-qt.menu
--- nvclock-0.8b4/debian/nvclock-qt.menu	2009-03-20 23:58:42.000000000 +0000
+++ nvclock-0.8b4/debian/nvclock-qt.menu	2009-03-20 23:58:42.000000000 +0000
@@ -1,6 +1,6 @@
 ?package(nvclock-qt):\
- needs=X11\
- section=Apps/System\
+ needs="X11"\
+ section="Applications/System/Hardware"\
  longtitle="nvclock: overclock your nVidia card (Qt GUI)"\
  title="Nvclock for Qt"\
  command="/usr/bin/nvclock_qt"
diff -Nru nvclock-0.8b4/debian/nvclock.postinst nvclock-0.8b4/debian/nvclock.postinst
--- nvclock-0.8b4/debian/nvclock.postinst	2009-03-20 23:58:42.000000000 +0000
+++ nvclock-0.8b4/debian/nvclock.postinst	1970-01-01 00:00:00.000000000 +0000
@@ -1,31 +0,0 @@
-#!/bin/sh
-# postinst script for nvclock
-#
-# Mostly stolen from the Debian xdm scripts
-# Copyright 1998, 1999 Branden Robinson.  Licensed under the GNU GPL.
-# Acknowlegements to Stephen Early, Mark Eichin, and Manoj Srivastava.
-#
-# see: dh_installdeb(1)
-
-set -e
-#. /usr/share/debconf/confmodule
-# db_version 2.0
-
-case "$1" in
-    configure)
-    ;;
-    abort-upgrade|abort-remove|abort-deconfigure)
-    ;;
-
-    *)
-        echo "postinst called with unknown argument \`$1'" >&2
-        exit 1
-    ;;
-esac
-
-# dh_installdeb will replace this with shell code automatically
-# generated by other debhelper scripts.
-
-#DEBHELPER#
-
-exit 0
diff -Nru nvclock-0.8b4/debian/rules nvclock-0.8b4/debian/rules
--- nvclock-0.8b4/debian/rules	2009-03-20 23:58:42.000000000 +0000
+++ nvclock-0.8b4/debian/rules	2009-03-20 23:58:42.000000000 +0000
@@ -4,9 +4,6 @@
 # Uncomment this to turn on verbose mode.
 #export DH_VERBOSE=1
 
-# This is the debhelper compatability version to use.
-export DH_COMPAT=5
-
 #WTF was this for?
 #bindir = $(CURDIR)/debian/ksimus/usr/bin
 
@@ -48,8 +47,7 @@
 debian-clean:
 	dh_testdir
 	-rm -f *-stamp
-	- $(MAKE) clean
-	-$(MAKE) distclean
+	[ ! -f Makefile ] || $(MAKE) distclean
 
 install: build
 	dh_testdir

Reply via email to