Bug#517069: inn2: mailpost does not exit with error

[Julien ÉLIE]

--- mailpost.in 2009-02-27 18:50:53 UTC (rev 8358)
+++ mailpost.in 2009-02-27 18:54:27 UTC (rev 8359)
@@ -510,8 +510,9 @@
    close SENDMAIL ;
#    unlink $tmpfile ;
-
-    exit (0) ; # Using a non-zero exit may cause problems.
+
+    # We use here a non-zero exit.  It should normally not cause problems.
+    exit(1);
}



Another changes from INN 2.5.0 as for this issue:

===================================================================
--- mailpost.in 2009-03-01 18:48:50 UTC (rev 8369)
+++ mailpost.in 2009-03-01 19:14:52 UTC (rev 8370)
@@ -333,7 +333,8 @@

if ( ! $tmpfile ) {
    # We had to bail and mail the article to the admin.
-    exit (0) ;
+    print STDERR "The creation of the temporary file $tmpfile failed.\n" if -t 
STDERR;
+    exit(1);
}


@@ -377,7 +378,10 @@

if (defined $DATABASE{$message_id}) {

-  exit 0 if (!$opt_c) ;
+  if (!$opt_c) {
+    print STDERR "Duplicate article <$message_id>.\n" if -t STDERR;
+    exit(1);
+  }

## crosspost -c
  $newsgroups = &append_newsgroups($DATABASE{$message_id}, $newsgroups) ;
@@ -399,7 +403,8 @@
if ($opt_c) {
  if (fork() != 0) {
    undef $tmpfile;  # Don't unlink $tmpfile.
-    exit 0;
+    print STDERR "An error occurred during the fork.\n" if -t STDERR;
+    exit(1);
  }
  sleep $opt_c ;

@@ -430,7 +435,7 @@

  if (defined($dup)) {
    syslog("err", "mismatch $newsgroups\n") if $debugging && $use_syslog;
-    exit 0 ;
+    exit(1);
  }

  # Replace Newsgroups:.
@@ -604,9 +609,9 @@
of unknown headers).

If the article has been seen before (B<mailpost> records the Message-ID of
-each article it handles), then the article will be silently dropped.  Other
-errors will cause the article to be mailed to the newsmaster (selected
-at configure time and defaulting to C<usenet>).
+each article it handles), then the article will be dropped with a non-zero
+error status.  Other errors will cause the article to be mailed to the
+newsmaster (selected at configure time and defaulting to C<usenet>).

Normally, B<mailpost> is run by sendmail(8) via an alias entry:



They could be backported to INN 2.4.6 if you want.

--
Julien ÉLIE

« -- Nous parlerons quand l'interprète dormira.
 [Bong !]
 -- Il dort. On peut parler. » (Astérix) 




--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org