On Fri, 2009-02-13 at 09:36 +0800, jida...@jidanni.org wrote:
> The man page makes it appear that using '--no-default-keyrings' will
> silence these error messages. But it doesn't.
> $ who-uploads --no-default-keyrings wwwoffle
> Could not find keyring /usr/share/keyrings/debian-keyring.gpg, skipping it
> Could not find keyring /usr/share/keyrings/debian-keyring.pgp, skipping it
> Could not find keyring /usr/share/keyrings/debian-maintainers.gpg, skipping it

It doesn't explicitly say that it won't even look for the keyrings, just
that it won't use them in order to decide who made an upload; I can see
how one could be inferred from the other though.

It's fairly easy to prove that who-uploads *doesn't* ignore
--no-default-keyrings at all. Specifically:

/=================================================================
|
| $ ls -ltr /usr/share/keyrings/
| total 25476
| -rw-r--r-- 1 root root   501702 2009-01-13 11:02 debian-maintainers.gpg
| -rw-r--r-- 1 root root     4876 2009-01-18 13:46 debian-role-keys.gpg
| -rw-r--r-- 1 root root   722198 2009-01-18 13:46 debian-keyring.pgp
| -rw-r--r-- 1 root root 24796809 2009-01-18 13:46 debian-keyring.gpg
| -rw-r--r-- 1 root root     4800 2009-01-31 22:31 
debian-archive-removed-keys.gpg
| -rw-r--r-- 1 root root     5801 2009-01-31 22:31 debian-archive-keyring.gpg
|
| $ who-uploads devscripts
| Uploads for devscripts:
| 2.10.46 to unstable: Adam D. Barratt <a...@adam-barratt.org.uk>
| 2.10.35lenny3 to testing: Adam D. Barratt <a...@adam-barratt.org.uk>
| 2.9.26etch2 to stable: Adam D. Barratt <a...@adam-barratt.org.uk>
|
| $ who-uploads --no-default-keyrings devscripts
| Uploads for devscripts:
| 2.10.46 to unstable: <unrecognised public key (345E3A85)>
| 2.10.35lenny3 to testing: <unrecognised public key (345E3A85)>
| 2.9.26etch2 to stable: <unrecognised public key (345E3A85)>
|
\=================================================================

The problem is that the message is generated whilst parsing the
configuration file, at which point who-uploads has no idea that you've
passed --no-default-keyrings on the command line. We could move the
checking of the configuration file keyrings to after the command line
parsing, although that would give a slightly odd ordering to the warning
messages.

Regards,

Adam



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to