Please note: the double free part of the patch has been applied upstream. Please apply to Ubuntu Hardy GDM.

Cheers, Chris.

http://bugzilla.gnome.org/show_bug.cgi?id=530585#c13

------- Comment #13 from Brian Cameron  2009-02-05 22:27 UTC -------

Thanks. I committed the patch to the 2.20 branch with a minor change. I removed the g_assert's from the calls to g_shell_parse_argv. I worry that asserting could cause the daemon to exit which would cause problems for any running displays, I'd think. I would accept any further patches to improve the error handling, but I suspect just asserting isn't the best answer here. Otherwise the patch looks correct. The double-free problem is a pretty obvious bug..
--
Aptivate | http://www.aptivate.org | Phone: +44 1223 760887
The Humanitarian Centre, Fenner's, Gresham Road, Cambridge CB1 2ES

Aptivate is a not-for-profit company registered in England and Wales
with company number 04980791.




--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to