Hi, > Maybe this should be considered more than a minor bug. This prevents > anyone from using normalize-mp3 without changing the code or using > undocumented tokens in the value of the --mp3encode command-line > argument.
The tokens are documented in the manpage as well as in the --help output. Here you can also see that the --mp3encode parameter is intended to specify the command as well as its arguments. And you can see that it is necesary to quote string and that there is no default encoder set. Did you read #29? This bug will get fixed (independent of its severity) once lenny is out of the door. We are in freeze (and have been since the problem was reported). I doubt that the release managers would approve an upload that just improves support for a piece of software that's not even in Debian. I also mentioned in #29 that the option is documented. [snip analysis] > I'd recommend putting lame into the script and listing it as a > requirement along with mpg123, oggdec/oggenc, and flac, which are > already hard-coded. I cannot simply depend on lame during the build process, because there is no such encoder in Debian. I will just patch "lame" into the default setting, because that is probably the most often used encoder. > Then remove the --mp3encode, --mp3decode, > --oggencode, --oggdecode command-line arguments. They can't be used > without quoting the argument and including the undocumented tokens > anyway. That is upstream's decision, not mine. And I won't recommend it to upstream, since that is definitely a wanted feature and the tokens are documented. The quoting is unavoidable (and not in the hands of normalize-mp3). > If the ability to choose the encoders/decoders from the command-line > is considered an important feature, it could be done by separating the > encoder and the arguments into two different variables. I don't see the benefit (except if the default argument string is by accident the right one). Joachim -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
