Patrik Fimml un jour écrivit:
Okay, I think I found the real culprit. In various places, network.cc
limits output to non-control characters by comparing with 0x20. On x86,
char is signed and 0xFF will be (-1), thus being treated as control
character. On ppc, chars are unsigned AFAIK, and 0xFF will be (255), and
passed on to the rest of the code.
Ah, I should have tough about it. Yes, I confirm that char are
unsigned for PowerPC, because managing signed char takes few more
instructions on PowerPC than unsigned one (though the diffirence shouldn't
be mesurable in our case).
It means that other architectures are also broken and will need to be
recompiled (ARM came to my mind).
154 if (buffer.front()>=32)
219 if (c>=0x20)
294 if (c>=0x20)
My fix for the time being would be to duplicate behaviour as on x86,
using signed chars everywhere (as I suspect that other bugs might arise
otherwise). A patch to the source package is attached, would you please
try if that fixes the problem?
I think you should simply cast "c" to a signed byte just to make more
obvious how silly this hack is :o)
More seriously, It seems to works now, thank you.
The only weird thing I noticed is when playing offline against a
computer, when the computer sometime played illegal moves (at least it is
what eboard claimed before letting me play twice in a row) and sometime
the computer being allowed to play 2 moves in a row. If I believe the
quality of the code we examined, they are probably just some other
unrelated bugs that also affect x86 systems.
Also, I saw many very bad mistakes in the French translation, including
one case for Bughouse where "partner" was translated as opponent, and one
big grammar error in the sub menu + many typo.
Since you are going to upload a new version anyway, I think it would be
important to take it as an opportunity to improve the translation as well.
I have completed the translation of every string in the .po file except
for "Helper program not found" that I am still not sure of how I should
translate it to French. I'll ask for a review on the debian french
translation mailing list, and send to you directly the new .po file (and a
copy for the actual French translator for eboard).
If you don't want to wait, I'll send you right away what I have, which
can't be worst that the past translation.
I also spoted an error in the Japanese version.
Simon Valiquette
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
