Package: wiipdf
Version: 1.1-1
Severity: normal
Tags: patch
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu jaunty ubuntu-patch
Hi,
In Ubuntu the buildds build everything with -D_FORTIFY_SOURCE=2
by default, which among other things turns on warnings when return
codes of functions with the __warn_unused attribute set are not
checked.
Your package hit this check as it doesn't check the return code of
system(). Attached is a patch to correct this.
Please consider applying it.
Thanks,
James
diff -u wiipdf-1.1/debian/changelog wiipdf-1.1/debian/changelog
only in patch2:
unchanged:
--- wiipdf-1.1.orig/wiipdf.c
+++ wiipdf-1.1/wiipdf.c
@@ -51,7 +51,10 @@
fprintf(stderr, "Error allocating memory\n");
exit(1);
}
- system(buffer);
+ if (!system(buffer)) {
+ fprintf(stderr, "Error executing xpdf\n");
+ exit(1);
+ }
}
static void quit_xpdf() {
@@ -60,7 +63,10 @@
fprintf(stderr, "Error allocating memory\n");
exit(1);
}
- system(buffer);
+ if (!system(buffer)) {
+ fprintf(stderr, "Error executing xpdf\n");
+ exit(1);
+ }
}
/*
