tags 293340 + patch pending
thanks
* Martin Michlmayr <[EMAIL PROTECTED]> [2005-02-02 16:13]:
> There is an inconsistency with the values reported for boolean
> variables. It says "False" for false but "1" for true values. It
> should use the same scheme for both:
>
> --vbr, -v generate variable bitrate files [False] +
> vs
> --vbr, -v generate variable bitrate files [1] +
>
> In fact, given that jack accepts "yes"/"no" and not 1/0 or True/False,
> it should probably say "yes"/"no".
Actually, here's a really simple fix for this:
diff -urN jack-3.1.1~/jack_utils.py jack-3.1.1/jack_utils.py
--- jack-3.1.1~/jack_utils.py 2005-06-19 19:43:29.001768184 +0100
+++ jack-3.1.1/jack_utils.py 2005-06-19 19:52:14.788836400 +0100
@@ -135,7 +135,7 @@
s = "yes"
else:
s = "no"
- if what['type'] == types.StringType:
+ elif what['type'] == types.StringType:
s = "'%s'" % what['val']
else:
s = str(what['val'])
The first if (checking for 'toggle') is completely ignored because of
the second if - it will simply use the else branch.
--
Martin Michlmayr
http://www.cyrius.com/
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
