Package: fluxconf
Version: 0.9.9-1
Followup-For: Bug #494510

I'm still able to reproduce the issue. If I just open fluxkeys and click 'save'
(without changing anything) it rewrites the ~/.fluxbox/keys file and instead of
"OnDesktop " it uses "None ", as Jens Schüßler <j...@trash.net> already said.
This is a problem when used with fluxbox 1.0.

The attached patch (untested) should do the trick. It seems it was adding "None"
when no button was selected on the gui interface. This patch just adds
"OnDesktop" instead of "None" when there's no button selected on the gui
interface.

"OnDesktop" appears to be for mouse events[1], but I tried this: modify by hand
the keys file and add a line with: "OnDesktop 9 :PrevWorkspace". And this makes
fluxbox change the workspace everytime 9 is pressed (besides the focus is on a
window or not). So, the result isn't that 'anti-intutive' when used with a
keyboard key.

I dont search/ask if its defined the behaviour of using keyboard keys with
"OnDesktop", but I think a more complicated patch would be needed to check if
its a keyboard key or not (I guess, I dont really know), and perhaps unsuitable
for lenny ? The attached patch should work with lenny's version of fluxbox and
its really small.

Please test the patch, I will try to install the build-depencies and recompile
over the weekend and test it too.




Thanks a lot,
Rodrigo

-- System Information:
Debian Release: 5.0
  APT prefers testing
  APT policy: (990, 'testing'), (200, 'experimental'), (200, 'unstable')
Architecture: i386 (i686)

Kernel: Linux 2.6.26-1-686 (SMP w/1 CPU core)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages fluxconf depends on:
ii  libatk1.0-0                   1.22.0-1   The ATK accessibility toolkit
ii  libc6                         2.7-16     GNU C Library: Shared libraries
ii  libcairo2                     1.6.4-7    The Cairo 2D vector graphics libra
ii  libfontconfig1                2.6.0-3    generic font configuration library
ii  libglib2.0-0                  2.16.6-1   The GLib library of C routines
ii  libgtk2.0-0                   2.12.11-4  The GTK+ graphical user interface 
ii  libpango1.0-0                 1.20.5-3   Layout and rendering of internatio
ii  libx11-6                      2:1.1.5-2  X11 client-side library
ii  libxcursor1                   1:1.1.9-1  X cursor management library
ii  libxext6                      2:1.0.4-1  X11 miscellaneous extension librar
ii  libxfixes3                    1:4.0.3-2  X11 miscellaneous 'fixes' extensio
ii  libxi6                        2:1.1.4-1  X11 Input extension library
ii  libxinerama1                  2:1.0.3-2  X11 Xinerama extension library
ii  libxrandr2                    2:1.2.3-1  X11 RandR extension library
ii  libxrender1                   1:0.9.4-2  X Rendering Extension client libra

Versions of packages fluxconf recommends:
ii  fluxbox                     1.0.0+deb1-8 Highly configurable and low resour

fluxconf suggests no packages.

-- no debconf information
--- fluxkeys.c.orig     2009-01-03 01:34:01.000000000 -0200
+++ fluxkeys.c  2009-01-03 01:34:10.000000000 -0200
@@ -378,9 +378,9 @@
         if (strlen(key)) {
             if (!mod)
 #ifndef DEBUG
-                fprintf(file, "None ");
+                fprintf(file, "OnDesktop ");
 #else
-                g_print("None ");
+                g_print("OnDesktop ");
 #endif
             else {
                 if (mod & 1)

Reply via email to