On Mon, Dec 29, 2008 at 05:01:45PM -0500, Michael Gilbert wrote: > > - I have no idea why this loop is here, anyway. Why would the -restart > > command ever fail?
> "-restart" will fail whenever a screensaver is active. this allows the > process to wait for the user to unlock the screen before proceeding with > the upgrade. Ah, ok. > > - The script, as written, also doesn't take into account the need to check > > for multiple instances of xscreensaver running on multiple displays. > > "-restart" will fail if there are any xscreensaver instances running, so i > think this is handled. No, it will only know xscreensaver instances were running if they're associated with the current user or X session. Running xscreensaver -restart as root won't affect any of the user instances. > > - Also, the -deactivate command will not unlock a screen that has been > > locked; so any screen that manages to be locked (perhaps by a direct user > > action) would still end up locking the user out. > agreed. this doesn't prevent the user from screwing up the process. > perhaps another "-restart" check could be added to determine whether the > user had locked the screen again. No, that's still a race condition. Anyway, the fix for this bug is now pending in the repo. -- Steve Langasek Give me a lever long enough and a Free OS Debian Developer to set it on, and I can move the world. Ubuntu Developer http://www.debian.org/ slanga...@ubuntu.com vor...@debian.org -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
