On Fri, 2008-12-12 at 17:26 +0100, Bas Zoetekouw wrote: > Hi Ben! > > You wrote: > > > I've made a few important fixes to avoid zombie processes (an existing > > bug) and file descriptor leakage. The new version of this patch is > > below. > > Unfortunately when I gave this code some serious testing I found a race > > condition in xdg-screensaver that can leave child processes hanging > > around if the user toggles between pause and play rapidly. There also > > seems to be a bug in xprop, which it relies on, that means the > > screensaver might not be resumed when we quit. So I can't recommend > > this fix at the moment. > > How severe are these bugs? Looking at #508125 (that is the > xdg-screensaver bug you mean, right?), it doesn't look too bad. > Also #508126 doesn't look like it should be holding back the release. > > Would it be ok to apply your patch and fix #508125 and #508126 post-lenny?
I don't think my patch is an improvement to xine so long as those bugs are unfixed. However, I have found quite simple fixes for them now. Ben. -- Ben Hutchings The program is absolutely right; therefore, the computer must be wrong.
signature.asc
Description: This is a digitally signed message part
