severity 498308 minor thanks Hi Jari
On Wed, Sep 10, 2008 at 07:05:1888AM +0300, Jari Aalto wrote: > Ola Lundqvist <[EMAIL PROTECTED]> writes: > > > Hi Jaalto > > > > On Tue, Sep 09, 2008 at 12:47:18AM +0300, jaalto wrote: > >> Package: ntop > >> Version: 3:3.3-11+b2 > >> Severity: normal > >> > >> > >> /etc/default/ntop reads: > >> > >> # This file will normally include the debconf template but you can > >> disable > >> # that and use this file only. > >> > >> . /var/lib/ntop/init.cfg > >> #GETOPT="" > >> > >> The variables that can be set are not mentioned. > > > > The variables to use are any variables for /etc/init.d/ntop > > Please add those in comments to the /etc/default/ntop file. Yes that is a good thing to do. > >> SUGGESTION > >> > >> Please make it read: > >> > >> # This file will normally include the debconf template but you can > >> disable > >> # that and use this file only. > >> . /var/lib/ntop/init.cfg > >> # GETOPT="" > >> + # USER="ntop" > >> + # INTERFACES="eth0" > >> > >> I wonder what is GETOP for? Perhaps a comment beside it would help to > >> orient reader better. > > > > See the /etc/init.d/ntop script. There you can see what $GETOPT and other > > variables are used for. > > 95 start-stop-daemon --start --quiet --name $NAME --exec $DAEMON -- \ > 96 -d -L -u $USER -P $HOMEDIR \ > 97 --access-log-file=$LOGDIR/access.log -i "$INTERFACES" \ > 98 -p /etc/ntop/protocol.list \ > 99 -O $LOGDIR $GETOPT > > It's better to document them in /etc/default/ntop and tell what to do. Of course. > > Also you can read in /var/lib/ntop/init.cfg what > > to set. > > It's not clear by reading /etc/init.d/ntop. This is how > /etc/default/nfs-kernel-server for example does it: Yes that is a good thing to add documentation. Patches are welcome. Best regards, // Ola > # Number of servers to start up > RPCNFSDCOUNT=8 > > # Runtime priority of server (see nice(1)) > RPCNFSDPRIORITY=0 > > # Options for rpc.mountd. > # If you have a port-based firewall, you might want to set up > # a fixed port here using the --port option. For more information, > # see rpc.mountd(8) or http://wiki.debian.org/?SecuringNFS > RPCMOUNTDOPTS= > > # Do you want to start the svcgssd daemon? It is only required for > Kerberos > # exports. Valid alternatives are "yes" and "no"; the default is "no". > NEED_SVCGSSD= > > # Options for rpc.svcgssd. > RPCSVCGSSDOPTS= > > >> I'm not sure the function of /var/lib/ntop/init.cfg because the > >> installation did not ask about any interface to define by default. > > > > If that is the case then you have set a "too low" debconf severity level > > for your installation. The questions are "medium" if eth0 is up and > > "high" if not. > > > > -- --------------------- Ola Lundqvist --------------------------- / [EMAIL PROTECTED] Annebergsslingan 37 \ | [EMAIL PROTECTED] 654 65 KARLSTAD | | http://inguza.com/ +46 (0)70-332 1551 | \ gpg/f.p.: 7090 A92B 18FE 7994 0C36 4FE4 18A1 B1CF 0FE5 3DD9 / --------------------------------------------------------------- -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
