Hi Dmitry, You should probably report this one directly upstream, but before you do, please read: http://mingw.org/Reporting_Bugs ... in particular the part about them requiring you to provide references to the source of the information that you used to create this patch. Without such a reference to documentation that we can freely draw from to provide the missing symbols you require, I'm afraid they probably won't be able to apply this patch. The mingw api is released under a very liberal licence so they cannot accept code that has been taken or derived from looking at the code of other vendors that is under a more restrictive licence.
For much the same reason it would be much better if you vouch this to them directly. Sorry. I can make new packages if you get it applied, but we should follow their process for getting it accepted first. If in doubt, it's probably best to ask them if a particular reference will be satisfactory before you post the patch to them. Cheers, Ron On Tue, Dec 02, 2008 at 05:11:57AM +0300, Dmitry Potapov wrote: > Package: mingw32-runtime > Version: 3.13-1 > Severity: normal > Tags: patch > > The definition of _TSCHAR, _TUCHAR, _TXCHAR, _TINT are missing in > tchar.h. The types are normal present in tchar.h shipped by Microsoft > and other vendors, so the lack of them makes impossible to use MinGW > to compile the source code that rely on these types. > > The lack of _TUCHAR is the most unfortunate, because the cast to _TUCHAR > is often necessary to guarantee that in non-UNICODE case, the argument > of character classification routines is inside of the allowed range. > For example: > > _TCHAR *ptr; > if (isdigit((_TUCHAR)*ptr)) > do_something(); > > If the cast to _TUCHAR were omitted then in non-UNICODE case (i.e. when > TCHAR is char) the argument of isdigit may become negative, which is not > allowed by the C standard. > > I have attached the patch that correct this problem. In this patch, I > also moved the definition of _TCHAR inside __TCHAR_DEFINED ifdef block. > (If the _TCHAR_DEFINED macro is defined, it means that TCHAR type is > defined, while __TCHAR_DEFINED means the same for _TCHAR). > > Dmitry -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
