Bug#507180: kstart: Missing required mode argument to open() call with O_CREAT

[James Westby]

Package: kstart
Version: 3.14-1
Severity: normal
Tags: patch
User: [EMAIL PROTECTED]
Usertags: origin-ubuntu jaunty ubuntu-patch

Hi,

open(2) requires that a mode is specified if the O_CREAT flag is given,
and one of the tests in your package fails to do that. The compiler in
Ubuntu catches these errors, so it failed to build there.

Attached is a patch that will correct this. Please consider applying it.

Thanks,

James

--- kstart-3.14.orig/tests/portable/daemon-t.c
+++ kstart-3.14/tests/portable/daemon-t.c
@@ -33,7 +33,7 @@
 {
     int fd;
 
-    fd = open("daemon-sentinel", O_RDWR | O_CREAT);
+    fd = open("daemon-sentinel", O_RDWR | O_CREAT, 0600);
     close(fd);
 }