Bug#507044: ifmail: Missing mode to open() call with O_CREAT

[James Westby]

Package: ifmail
Version: 2.14tx8.10-19.4
Severity: normal
Tags: patch
User: [EMAIL PROTECTED]
Usertags: origin-ubuntu jaunty ubuntu-patch

Hi,

In ifgate/flock.c there is a call to open() with the O_CREAT option,
but with no mode specified. open() requires that you specify a mode
when O_CREAT is given.

I propose the following patch to rectify this. Please consider applying
it.

Thanks,

James

--- ifmail-2.14tx8.10.orig/ifgate/flock.c
+++ ifmail-2.14tx8.10/ifgate/flock.c
@@ -15,7 +15,7 @@
 
        if (fn)
        {
-               if ((lfd=open(fn,O_RDWR | O_CREAT)) < 0)
+               if ((lfd=open(fn,O_RDWR | O_CREAT,0600)) < 0)
                {
                        logerr("$Error opening file %s",fn);
                        return -1;