Hi,

Sorry for the delay.

2008/11/21 dann frazier <[EMAIL PROTECTED]>:
> Thanks for the report. Does this patch look sufficient to you?
>
> --- flamethrower-0.1.8.orig/bin/flamethrower
> +++ flamethrower-0.1.8/bin/flamethrower
> @@ -9,6 +9,7 @@
>
>  use strict;
>  use File::Path;
> +use File::Temp;
>  use Getopt::Long;
>
>  use lib "/usr/lib/flamethrower";
> @@ -23,7 +24,7 @@
>  my $version_number  = "INS_VERSION";
>  my $conf_file       = '/etc/flamethrower/flamethrower.conf';
>  my $transport       = "udp-receiver";
> -my $tmp_dir         = "/tmp/.flamethrower.$$";
> +my $tmp_dir         = File::Temp::tempdir("/tmp/flamethrower.XXXXXX");

You could even omit the template and let tempdir create a directory
with a random name under $TMPDIR (instead of hard-coding /tmp).

Same as for the other calls. Other than that it does look good.

Cheers,
-- 
Raphael Geissert - Debian Maintainer
www.debian.org - get.debian.net

P. J. O'Rourke  - "Never wear anything that panics the cat."



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to