Jan Hauke Rahm a scris: > Hey, > me again... > > On Fri, Nov 21, 2008 at 07:03:05PM +0200, Eddy Petrișor wrote: >> *Functionally* wouldn't only this part (and the code for the added >> option) be enough? >> >> - $trunkdir = "$package/trunk"; >> + # NB: no :) >> + $workingdir="$package/trunk"; >> + $workingdir="$package/branches/$opt_branch" if ($opt_branch); >> withecho "svn up"; > > If I cut out all comments and stuff and don't change "trunkdir" to > "workingdir" etc. it seems to lead to the attached patch (which is btw > now based on the latest trunk of svn-buildpackage in collab-maint).
Sorry man, I wasn't too clear on my question. I wasn't asking for the change to be done, I was asking to double check that I understood the patch properly. > It's obviously a lot shorter and better readable, although I may say > that I still don't think it makes sense to leave "trunk" in variables > which actually mean something different, but that's to be thought about > when addressing #365116. Sorry for the extra work I've put you through, it was unintentional. I saw you started pinging bug submitters, that's great! -- Regards, EddyP ============================================= "Imagination is more important than knowledge" A.Einstein -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
