Package: doodle
Version: 0.6.7-3
Severity: normal
Tags: patch
User: [EMAIL PROTECTED]
Usertags: origin-ubuntu jaunty ubuntu-patch

Hi,

In src/doodle/doodled.c there is a call to open(2) with
O_CREAT as one of the flags. When O_CREAT is specified the
program must also specify the mode to use if creating the
file.

Newer compilers can be made to check for this, and will cause
a build failure if found.

Attached is a suggested patch, please consider applying it
or solving the problem in another way. As it is /dev/null it
would be a rare occurrence, and maybe moving O_CREAT to get
an error in that case would be reasonable. I chose to use
a restrictive mode, which may not be correct for /dev/null,
which is mode 644 by default.

Thanks,

James

Attachment: 02-open-arguments.dpatch
Description: application/shellscript

Reply via email to