On Tue, Nov 11, 2008 at 22:26:22 +0100, Andreas Barth wrote:
> > > The following keywords seem to be no longer understood:
> > > pkcs11-id-type
> > > pkcs11-slot-type
> > > pkcs11-slot

[...]

> I think it would be great if these special keywords could make openvpn
> to say "these keywords are no longer supported, please read
> /usr/.../NEWS.Debian.gz for details".

OK, I tried my hand at this; a patch for options.c is attached. I tested
it on my Sid/i386 laptop and it seems to work.
--- a/options.c	2008-11-12 14:37:57.000000000 +0100
+++ b/options.c	2008-11-12 20:04:52.000000000 +0100
@@ -5462,6 +5462,20 @@
       VERIFY_PERMISSION (OPT_P_GENERAL);
       options->pkcs11_id_management = true;
     }
+  else if (streq (p[0], "pkcs11-id-type") ||
+           streq (p[0], "pkcs11-sign-mode") ||
+           streq (p[0], "pkcs11-slot") ||
+           streq (p[0], "pkcs11-slot-type") ||
+           streq (p[0], "show-pkcs11-objects") ||
+           streq (p[0], "show-pkcs11-slots"))
+    {
+      if (file)
+	msg (msglevel, "You are using an obsolete parameter in %s:%d: %s (%s).\nPlease see /usr/share/doc/openvpn/NEWS.Debian.gz for details.",
+             file, line, p[0], PACKAGE_VERSION);
+      else
+	msg (msglevel, "You are using an obsolete parameter: --%s (%s).\nPlease see /usr/share/doc/openvpn/NEWS.Debian.gz for details.",
+             p[0], PACKAGE_VERSION);
+    }
 #endif
 #ifdef TUNSETPERSIST
   else if (streq (p[0], "rmtun"))

Reply via email to