Package: incron
Version: 0.5.7-1
Severity: minor
The following patch enables several warning flags that I routinely use.
I tried "-pedantic" but it can't compile with that flag. It would be
good if the code could be cleaned up so that it can compile with
-pedantic too.
diff -ru incron-0.5.7.b/Makefile incron-0.5.7/Makefile
--- incron-0.5.7.b/Makefile 2008-10-30 11:37:40.000000000 +1100
+++ incron-0.5.7/Makefile 2008-10-30 11:40:43.000000000 +1100
@@ -14,7 +14,7 @@
OPTIMIZE = -O2
DEBUG = -g0
-WARNINGS = -Wall
+WARNINGS = -Wall -W -Wshadow -Wpointer-arith -Wwrite-strings -ffor-scope
CXXAUX = -pipe
CXXFLAGS = $(OPTIMIZE) $(DEBUG) $(WARNINGS) $(CXXAUX)
diff -ru incron-0.5.7.b/incrontab.cpp incron-0.5.7/incrontab.cpp
--- incron-0.5.7.b/incrontab.cpp 2007-09-05 01:48:33.000000000 +1000
+++ incron-0.5.7/incrontab.cpp 2008-10-30 11:39:22.000000000 +1100
@@ -112,9 +112,9 @@
rEntry.m_uMask = (uint32_t) u;
}
else {
- StringTokenizer tok(s2);
- while (tok.HasMoreTokens()) {
- std::string s(tok.GetNextToken());
+ StringTokenizer tok2(s2);
+ while (tok2.HasMoreTokens()) {
+ std::string s(tok2.GetNextToken());
if (s == "IN_NO_LOOP")
rEntry.m_fNoLoop = true;
else
-- System Information:
Debian Release: 4.0
APT prefers stable
APT policy: (990, 'stable')
Architecture: i386 (i686)
Shell: /bin/sh linked to /bin/bash
Kernel: Linux 2.6.18-6-686
Locale: LANG=en_AU.UTF-8, LC_CTYPE=en_AU.UTF-8 (charmap=ANSI_X3.4-1968)
(ignored: LC_ALL set to C)
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
