Package: pppoe
Version: 3.5-4
Followup-For: Bug #298185

The reason pppoe-server -k isn't working is that the configure script
conflates 2 configuration items that should be separate:

1. Do you want to build the pppd plugin (no, we don't because it's already
included in the ppp-2.4.3 package)
2. Do you want to _use_ the pppd plugin (yes, we do because kernel mode pppoe
is a Good Thing)

The configure script doesn't recognize this as valid. If you want to be able
to use the plugin from pppoe-server, you have to build it here too.

The relevant part of configure.in is:

if test "$ac_cv_header_linux_if_pppox_h" = yes ; then
        if test "$ac_cv_pluginpath" != no ; then
                LINUX_KERNELMODE_PLUGIN=rp-pppoe.so
                AC_DEFINE(HAVE_LINUX_KERNEL_PPPOE)
                PPPD_INCDIR=$ac_cv_pluginpath
        fi
fi

The AC_DEFINE(HAVE_LINUX_KERNEL_PPPOE) is what enables pppoe-server -k (and
it has no other effect). In my opinion, HAVE_LINUX_KERNEL_PPPOE should simply
be defined unconditionally, either by configure.in or by a #define in
pppoe-server.c after #include "config.h".

If -k is attempted on a system whose kernel or pppd doesn't support it,
connections will fail and you'll have to read your log to see that pppd
failed to load or initialize the plugin. This may be an argument against
making -k a default, but it's surely not a reason to keep kernel-mode support
out of Debian's pppoe-server forever.

-- System Information:
Debian Release: 3.1
Architecture: i386 (i686)
Kernel: Linux 2.4.29
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)

Versions of packages pppoe depends on:
ii  libc6                   2.3.2.ds1-22     GNU C Library: Shared libraries an
ii  ppp                     2.4.3-20050321+2 Point-to-Point Protocol (PPP) daem

-- no debconf information


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to