Package: rss2email
Version: 1:2.54-2
Severity: wishlist
Tags: patch
At the moment, rss2email's delete() is not very reliable. It allows
you to:
- remove the default email address ('feed' 0) and thereby hose your
feed file
- 'remove' entries that don't exist without warning
- says that IDs "may" have changed instead of only saying when they
really changed.
The patch below fixes these problems.
--- rss2email.py~ 2005-06-11 23:55:41.175869328 +0100
+++ rss2email.py 2005-06-11 23:55:20.877955080 +0100
@@ -445,8 +445,14 @@
def delete(n):
feeds, feedfileObject = load()
- feeds = feeds[:n] + feeds[n+1:]
- print >>warn, "W: feed IDs may have changed, list before deleting again"
+ if n == 0:
+ print >>warn, "W: ID has to be equal to or higher than 1"
+ elif n >= len(feeds):
+ print >>warn, "W: there's no feed matching ID %d" % n
+ else:
+ feeds = feeds[:n] + feeds[n+1:]
+ if n != len(feeds):
+ print >>warn, "W: feed IDs have changed, list before
deleting again"
unlock(feeds, feedfileObject)
def email(addr):
-- System Information:
Debian Release: 3.1
APT prefers unstable
APT policy: (500, 'unstable')
Architecture: i386 (i686)
Shell: /bin/sh linked to /bin/bash
Kernel: Linux 2.6.10-1-686
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Versions of packages rss2email depends on:
ii python 2.3.5-2 An interactive high-level object-o
-- no debconf information
--
Martin Michlmayr
http://www.cyrius.com/
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
