Fixed, see https://bugs.launchpad.net/decibel-audio-player/+bug/278470

Line 364:
- prevChar = None
+ prevChar = ''

Line 378:
- if prevChar is None or (prevChar != currChar and not
(prevChar.isdigit() and currChar.isdigit())):
+ if prevChar != currChar and not (prevChar.isdigit() and currChar.isdigit()):

On Sun, Oct 5, 2008 at 10:18, Yves-Alexis Perez <[EMAIL PROTECTED]> wrote:
> On dim, 2008-10-05 at 10:07 +0200, François Ingelrest wrote:
>> On Sat, Oct 4, 2008 at 21:59, Emilio Pozuelo Monfort <[EMAIL PROTECTED]> 
>> wrote:
>> > The other problem here is that AFAICS the artist tag shouldn't be empty, 
>> > but
>> > either the artist tag from the audio file, or UNKNOWN_ARTIST, which is
>> > _("Unknown Artist"). Unfortunately I haven't found where the source of the 
>> > issue
>> > may be.
>>
>> It's not exactly that: If the tag doesn't exist, then UNKNOWN_* is
>> used, otherwise the value of the tag is used. Here, the tag exists and
>> its value is an empty string:
>>
>> > [EMAIL PROTECTED]: python -c 'from mutagen.asf import ASF; print ASF("01 
>> > Piste
>> > 1.wma").get("Author")'
>> > [u'']
>
> Yes. Corner case, but which can exist, I guess. Depends on how mutagen
> reacts with various "empty" tags.
>>
>> So I can change the code that populates the library to avoid this
>> crash when the artist tag is an empty string, but in any case the
>> files should be correctly tagged if you want to get something
>> interesting displayed.
>
> Yeah, the tags are obviously wrong here, but it shouldn't prevent
> decibel to display something (even if it's "nothing" :) )
>
> Cheers, and thanks :)



--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to