Severity 488635 important Tags 488635 + patch thanks Hi Arthur,
I raise the severity of this issue, because I strongly disagree with your opinion on this. 1) It breaks functionality in a very common setup. 2) It breaks compatibility with libnss-ldap, which does not have the problem. Thats bad, as your solution is advertised as a replacement for it, because of the better design. However to be standards-compliant, while breaking functionaliy and compatibility is not really a good thing. Arthur de Jong wrote: > I don't think that having spaces in POSIX group names is a good idea > because it is bound to break stuff. I really don't think its up to you to decide wither having spaces in group names is a good idea or not. Fact is, that it works flawless in a common environment. Its no problem for the file-based databases or the default tools (chmod, chown and a like) where it "just works". It is what users of this tool want and need. But it is a problem with libnss-ldapd. Well, there are other tools that have similar constraints (like groupadd), but IMHO that does not count as an argument for such constraints in an _ldap based_ setup, which is often used in a mixed Windows and Linux environment. Anyway: As Andreas already said: It is a common setup, which works flawless with libnss-ldap (except the non-related flaws this has), so: No it does *not* break stuff. I've prepared a small patch, however I did not check, weither it needs more work (e.g. in your testsuite). Please consider including it. Thanks and best Regards, Patrick
--- nss-ldapd-0.6.5/nslcd/common.c 2008-10-01 12:19:45.069799284 +0200
+++ nss-ldapd-0.6.5.patched/nslcd/common.c 2008-10-01 11:53:36.362112215 +0200
@@ -98,7 +98,7 @@
(name[i]>='@' && name[i] <= 'Z') ||
(name[i]>='a' && name[i] <= 'z') ||
(name[i]>='0' && name[i] <= '9') ||
- name[i]=='.' || name[i]=='_' || name[i]=='$') )
+ name[i]=='.' || name[i]=='_' || name[i]=='$' || name[i] == ' ') )
return 0;
}
/* no test failed so it must be good */
signature.asc
Description: Digital signature
