severity 500492 serious retitle 500492 FTBFS on arm/armel/mips/mipsel/s390: dither.c:1252: error: unknown register name 'st(1)' in 'asm' tags 500492 + patch thanks
This is due to a broken configure check:
-snip-
checking for fldln2/fxch/fyl2x... yes
-snip-
1) these archs don't have these instructions, yet test succeeds
2) even if these instructions exist, it doesn't mean the have same
meaning on every arch...
Since I really don't want to dive in to autofoo to fix that that
properly, here is a band-aid portability fix.
--- libcaca-0.99.beta15.old/caca/dither.c 2008-09-27 15:58:05.000000000
+0000
+++ libcaca-0.99.beta15/caca/dither.c 2008-09-30 21:04:19.000000000 +0000
@@ -1236,7 +1236,7 @@
/* Compute x^y without relying on the math library */
static float gammapow(float x, float y)
{
-#ifdef HAVE_FLDLN2
+#if 0
register double logx;
register long double v, e;
#else
@@ -1247,7 +1247,7 @@
if(x == 0.0)
return y == 0.0 ? 1.0 : 0.0;
-#ifdef HAVE_FLDLN2
+#if 0
/* FIXME: this can be optimised by directly calling fyl2x for x and y */
asm volatile("fldln2; fxch; fyl2x"
: "=t" (logx) : "0" (x) : "st(1)");
--
"rm -rf" only sounds scary if you don't have backups
signature.asc
Description: Digital signature
