Package: fai-client
Version: 3.2.9
Severity: wishlist

Subject: fai-client: improve ainsl exit code
Package: fai-client
Version: 3.2.9
Severity: wishlist

It would be nice if ainsl's exit code would signal if it actually appended a
line, ie. return non-zero if a matching line was found or a usage error
occurred.

Regards,
        Christopher

-- System Information:
Debian Release: 4.0
  APT prefers stable
  APT policy: (900, 'stable')
Architecture: amd64 (x86_64)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.24-etchnhalf.1-amd64
Locale: LANG=en_US, LC_CTYPE=de_DE (charmap=ISO-8859-1)

Versions of packages fai-client depends on:
ii  file                        4.17-5etch3  Determines file type using "magic"
ii  libapt-pkg-perl             0.1.20       Perl interface to libapt-pkg
ii  libparse-recdescent-perl    1.94.free-3  Generates recursive-descent parser
ii  perl                        5.8.8-7etch3 Larry Wall's Practical Extraction 

Versions of packages fai-client recommends:
ii  debconf-utils                1.5.11etch2 debconf utilities

-- no debconf information

-- System Information:
Debian Release: 4.0
  APT prefers stable
  APT policy: (900, 'stable')
Architecture: amd64 (x86_64)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.24-etchnhalf.1-amd64
Locale: LANG=en_US, LC_CTYPE=de_DE (charmap=ISO-8859-1)

Versions of packages fai-client depends on:
ii  file                        4.17-5etch3  Determines file type using "magic"
ii  libapt-pkg-perl             0.1.20       Perl interface to libapt-pkg
ii  libparse-recdescent-perl    1.94.free-3  Generates recursive-descent parser
ii  perl                        5.8.8-7etch3 Larry Wall's Practical Extraction 

Versions of packages fai-client recommends:
ii  debconf-utils                1.5.11etch2 debconf utilities

-- no debconf information
--- /usr/bin/ainsl.orig 2008-09-26 16:12:19.000000000 +0200
+++ /usr/bin/ainsl      2008-09-26 16:15:50.000000000 +0200
@@ -53,7 +53,7 @@
 
 Report bugs to <[EMAIL PROTECTED]>.
 EOF
-  exit 0;
+  exit 2;
 }
 # - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
 sub autocreate {
@@ -113,7 +113,7 @@
   }
 }
 close(INFILE);
-exit 0 if $found; # nothing to append
+exit 1 if $found; # nothing to append
 # - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
 # Append line to file
 print "ainsl: appending to $filename: $line\n" if $verbose;

Reply via email to