Hello Matthew!

First of all, thanks for writing and providing ike.

On Wed, Sep 24, 2008 at 11:14:39AM -0500, Matthew Grooms wrote:
> Nicolas Deschildre wrote:
>> Thanks for the detailed bug report!
>> I'm forwarding upstream.
>>
>> Matthew : see http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=500027
>
> Thanks for the heads up. This and many other bugs have been fixed in the  
> 2.1.2 maintenance release.

I think this particular bug is NOT fixed in 2.1.2, since I still
encountered the bug of inet_addr() returning 255.255.255.255 because it
gets passed a non-\0-terminated string.

--- ike-2.1.2+dfsg.orig/source/iked/ike.peerid.cpp
+++ ike-2.1.2+dfsg/source/iked/ike.peerid.cpp
@@ -91,7 +91,7 @@
                        if( ph1->tunnel->peer->iddata_l.size() )
                        {
                                ph1id.addr.s_addr =
-                                       inet_addr( ( char * ) 
ph1->tunnel->peer->iddata_l.buff() );
+                                       inet_addr( 
ph1->tunnel->peer->iddata_l.text() );
                        }
                        else
                        {
@@ -160,7 +160,7 @@
                        if( ph1->tunnel->peer->iddata_r.size() )
                        {
                                ph1id.addr.s_addr =
-                                       inet_addr( ( char * ) 
ph1->tunnel->peer->iddata_r.buff() );
+                                       inet_addr( 
ph1->tunnel->peer->iddata_r.text() );
                        }
                        else
                        {
--- ike-2.1.2+dfsg.orig/source/libidb/libidb.cpp
+++ ike-2.1.2+dfsg/source/libidb/libidb.cpp
@@ -120,6 +120,11 @@
 
 char * _BDATA::text()
 {
+       if( data_size == data_real)
+       {
+               grow( data_real + 1 );
+       }
+       data_buff[ data_size ] = '\0';
        return ( char * ) data_buff;
 }
 

> Would it be possible to update the package?

I've built 2.1.2 for my private repository available from
http://pint.pmhahn.de/pmhahn/debian/lenny/i/ike/

BYtE
Philipp
-- 
Philipp Matthias Hahn <[EMAIL PROTECTED]>
 GPG/PGP: 9A540E39 @ keyrings.debian.org



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to