clone 485307 -1
reassign -1 insserv
retitle -1 insserv: Required-Stop $all changes start links
severity -1 important
tags -1 patch
tags -1 pending
retitle 485307 Should not specify special $all keyword in Required-Stop:
severity 485307 important
user 485307 [EMAIL PROTECTED]
usertag 485307 incorrect dependency
thanks
> Anyway, the issue with $all affecting both start and stop sequences is
> noted, a test case is written, and we will discuss with upstream how
> it should work.
Creating a separate bug report for this specific problem, which should be fixed
by attached patch. $all could probably be improved however, so I guess we need
to speak with upstream about this.
Thanks, Kel.
---
--- a/insserv.c
+++ b/insserv.c
@@ -291,8 +291,13 @@
break;
case '$':
if (strcasecmp(token, "$all") == 0) {
- serv->attr.flags |= SERV_ALL;
- break;
+ if (bit & REQ_KILL) {
+ /* $all has no effect on stop sort order */
+ break;
+ } else {
+ serv->attr.flags |= SERV_ALL;
+ break;
+ }
}
/* Expand the `$' token recursively down */
list_for_each(ptr, sysfaci_start) {
---
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
