On Fri, Sep 19, 2008 at 02:39:55PM +0300, Martin-Éric Racine wrote: > On Fri, Sep 19, 2008 at 2:29 PM, Agustin Martin <[EMAIL PROTECTED]> wrote: > > Note that your russian package has some hardcoded maintainer scripts with > > full > > program names included, copy of those created by the dictionaries-common-dev > > tools. > > That is correct. In fact, all of my dictionary packages (not just > Russian) have those hard-coded paths, because they are auto-generated > by the current version dictionaries-common-dev, which uses hard-coded > paths .
No, the maintainer scripts I mentioned are not generated by the installdeb* scripts. What the installdeb* scripts generate is something like aspell-ru.postinst.debhelper aspell-ru.postrm.debhelper irussian.postinst.debhelper irussian.postrm.debhelper myspell-ru.postinst.debhelper myspell-ru.postrm.debhelper that gets installed in the right place by debconf and removed in the clean target by dh_clean (cdbs internals should take care of this if the debhelper module is loaded). Maintainer scripts debian/aspell-ru.postinst debian/aspell-ru.postrm debian/irussian.postinst debian/irussian.postrm debian/myspell-ru.postinst debian/myspell-ru.postrm although presumably generated manually after their output, were not produced by the installdeb* scripts (note that they have a shebang line and a #DEBHELPER# token, which are not in the installdeb* templates) and, unless containing something extra to be done, can safely be removed. As a consequence of not removing them, all calls are done twice, one from the original script and other from the installdeb* generated part. See the really installed maintainer scripts. Those snippets seem to have slipped for the first time into diff.gz as of 0.99f9-3 (named then as something like postinst.debhelper) and became fully present with the actual names in 0.99f9-5. > > Those maintainer scripts should not be needed at all if the installdeb* > > scripts are used. > > Which makes one ownder why dictionaries-common-dev produces them, then? Does not produce them, see above. I have removed them and everything seems to work OK when building the package, being all the *debhelper stuff removed in the clean target. Attached patch show the changes (really too verbose to just show removal of those scripts) -- Agustin
diffstat for rus-ispell_0.99g5-4 rus-ispell_0.99g5-4.0.1 debian/aspell-ru.postinst | 13 ------------- debian/aspell-ru.postrm | 10 ---------- debian/irussian.postinst | 14 -------------- debian/irussian.postrm | 19 ------------------- debian/myspell-ru.postinst | 7 ------- debian/myspell-ru.postrm | 7 ------- rus-ispell-0.99g5/debian/changelog | 6 ++++++ 7 files changed, 6 insertions(+), 70 deletions(-) reverted: --- rus-ispell-0.99g5/debian/irussian.postrm +++ rus-ispell-0.99g5.orig/debian/irussian.postrm @@ -1,19 +0,0 @@ -#!/bin/sh -# Automatically added by installdeb-ispell -case "$1" in abort-install|remove) - - /usr/sbin/remove-default-ispell irussian - - if [ -e /usr/share/debconf/confmodule ] ; then - . /usr/share/debconf/confmodule - db_purge - fi -esac -# End automatically added section -# Automatically added by dh_installdebconf -if [ "$1" = purge ] && [ -e /usr/share/debconf/confmodule ]; then - . /usr/share/debconf/confmodule - db_purge -fi -# End automatically added section -#DEBHELPER# diff -u rus-ispell-0.99g5/debian/changelog rus-ispell-0.99g5/debian/changelog --- rus-ispell-0.99g5/debian/changelog +++ rus-ispell-0.99g5/debian/changelog @@ -1,3 +1,9 @@ +rus-ispell (0.99g5-4.0.1) unstable; urgency=low + + * Testing build. + + -- Agustin <[EMAIL PROTECTED]> Thu, 18 Sep 2008 13:17:41 +0200 + rus-ispell (0.99g5-4) unstable; urgency=high * Reverted Hash-Name changes for ispell RC bug (Closes: #497255). reverted: --- rus-ispell-0.99g5/debian/aspell-ru.postinst +++ rus-ispell-0.99g5.orig/debian/aspell-ru.postinst @@ -1,13 +0,0 @@ -#!/bin/sh -# Automatically added by installdeb-aspell -SCRIPT="/usr/sbin/update-dictcommon-aspell" -if [ "$1" = "configure" ] ; then - if [ -x "$SCRIPT" ]; then - $SCRIPT - else - echo "Error: $SCRIPT not present or executable. Missing dependency on dictionaries-common?" >&2 - exit 1 - fi -fi -# End automatically added section -#DEBHELPER# reverted: --- rus-ispell-0.99g5/debian/irussian.postinst +++ rus-ispell-0.99g5.orig/debian/irussian.postinst @@ -1,14 +0,0 @@ -#!/bin/sh -# Automatically added by installdeb-ispell -. /usr/share/debconf/confmodule -SCRIPT="/usr/sbin/update-default-ispell" -if [ "$1" = "configure" ] ; then - if [ -x "$SCRIPT" ]; then - $SCRIPT --rebuild - else - echo "Error: $SCRIPT not present or executable. Missing dependency on dictionaries-common?" >&2 - exit 1 - fi -fi -# End automatically added section -#DEBHELPER# reverted: --- rus-ispell-0.99g5/debian/myspell-ru.postrm +++ rus-ispell-0.99g5.orig/debian/myspell-ru.postrm @@ -1,7 +0,0 @@ -#!/bin/sh -# Automatically added by installdeb-myspell -if [ "$1" = "remove" ]; then - update-openoffice-dicts -fi -# End automatically added section -#DEBHELPER# reverted: --- rus-ispell-0.99g5/debian/myspell-ru.postinst +++ rus-ispell-0.99g5.orig/debian/myspell-ru.postinst @@ -1,7 +0,0 @@ -#!/bin/sh -# Automatically added by installdeb-myspell -if [ "$1" = "configure" ]; then - update-openoffice-dicts -fi -# End automatically added section -#DEBHELPER# reverted: --- rus-ispell-0.99g5/debian/aspell-ru.postrm +++ rus-ispell-0.99g5.orig/debian/aspell-ru.postrm @@ -1,10 +0,0 @@ -#!/bin/sh -# Automatically added by installdeb-aspell -case "$1" in abort-install|remove) - - if [ -x /usr/sbin/update-dictcommon-aspell ]; then - /usr/sbin/update-dictcommon-aspell - fi -esac -# End automatically added section -#DEBHELPER#
