Package: pbuilder
Version: 0.181
Severity: normal
Tags: patch

I keep a number of different hooks in my $HOME/.pbuilder/hooks/ 
directory, and some are symlinks to files outside that directory.

When 'pbuilder-runhooks' copies the hooks, it copies them without 
dereference, which fails inside the chroot since the referenced files 
are not found.

The attached patch, generated using 'git format-patch', fixes this by 
using the '-L' ('--dereference') option to 'cp' when copying the hook 
files into the pbuilder chroot.


-- System Information:
Debian Release: lenny/sid
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'stable'), (90, 'unstable')
Architecture: powerpc (ppc64)

Kernel: Linux 2.6.25-2-powerpc64 (SMP w/2 CPU cores)
Locale: LANG=en_AU.UTF-8, LC_CTYPE=en_AU.UTF-8 (charmap=UTF-8) (ignored: LC_ALL 
set to en_AU.UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages pbuilder depends on:
ii  cdebootstrap                  0.5.3      Bootstrap a Debian system
ii  coreutils                     6.10-6     The GNU core utilities
ii  debconf [debconf-2.0]         1.5.22     Debian configuration management sy
ii  debianutils                   2.30       Miscellaneous utilities specific t
ii  debootstrap                   1.0.10     Bootstrap a basic Debian system
ii  gcc                           4:4.3.1-2  The GNU C compiler
ii  wget                          1.11.4-1   retrieves files from the web

Versions of packages pbuilder recommends:
ii  cowdancer                     0.47       Copy-on-write directory tree utili
ii  devscripts                    2.10.35    scripts to make the life of a Debi
ii  fakeroot                      1.9.5      Gives a fake root environment
ii  sudo                          1.6.9p17-1 Provide limited super user privile

Versions of packages pbuilder suggests:
pn  pbuilder-uml                  <none>     (no description available)

-- debconf information:
  pbuilder/mirrorsite: http://cdn.debian.net/debian
  pbuilder/nomirror:
  pbuilder/rewrite: false

-- 
 \        “I spent a lot of money on wine and women, and like a fool I |
  `\                                 squandered the rest.” —Benny Hill |
_o__)                                                                  |
Ben Finney <[EMAIL PROTECTED]>
From 9a32aa69acdb1087f2a8a99a14ea6ab340706765 Mon Sep 17 00:00:00 2001
From: Ben Finney <[EMAIL PROTECTED]>
Date: Thu, 18 Sep 2008 14:53:29 +1000
Subject: [PATCH] Dereference symlinks when copying hooks.

---
 pbuilder-runhooks |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/pbuilder-runhooks b/pbuilder-runhooks
index 1bf66b7..ac500a2 100644
--- a/pbuilder-runhooks
+++ b/pbuilder-runhooks
@@ -37,8 +37,8 @@ function loadhooks () {
     fi
     if [ -d "$HOOKDIR" ]; then
 	mkdir -p "$BUILDPLACE/$hooks"
-	if ! cp -a "$HOOKDIR/"* "$BUILDPLACE/$hooks"; then
-	    echo "W: no hooks found on the hookdir" >&2 
+	if ! cp -aL "$HOOKDIR/"* "$BUILDPLACE/$hooks"; then
+	    echo "W: no hooks found in the hookdir '$HOOKDIR'" >&2 
 	fi
     fi
 }
-- 
1.5.6.5

Attachment: signature.asc
Description: Digital signature

Reply via email to