Bug#499162: dnsmasq: memory leak when sending initial DBUS message (Up)

[Jeremy Laine]

Package: dnsmasq
Version: 2.45-1
Severity: normal
Tags: patch

There seems to be a memory leak in the code that sends the initial message
on DBUS when dnsmasq comes up: the message is not freed.

Please find a patch attached.

Cheers,
Jeremy

-- System Information:
Debian Release: lenny/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.25-2-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages dnsmasq depends on:
ii  adduser                       3.110      add and remove users and groups
ii  dnsmasq-base                  2.45-1     A small caching DNS proxy and DHCP
ii  netbase                       4.34       Basic TCP/IP networking system

dnsmasq recommends no packages.

Versions of packages dnsmasq suggests:
pn  resolvconf                    <none>     (no description available)

-- no debconf information

diff -urN dnsmasq-2.45.orig/src/dbus.c dnsmasq-2.45/src/dbus.c
--- dnsmasq-2.45.orig/src/dbus.c	2008-07-20 21:18:16.000000000 +0200
+++ dnsmasq-2.45/src/dbus.c	2008-09-16 19:14:41.000000000 +0200
@@ -283,7 +283,10 @@
   daemon->dbus = connection; 
   
   if ((message = dbus_message_new_signal(DNSMASQ_PATH, DNSMASQ_SERVICE, "Up")))
-    dbus_connection_send(connection, message, NULL);
+    {
+      dbus_connection_send(connection, message, NULL);
+      dbus_message_unref(message);
+    }
 
   return NULL;
 }