Nathanael Nerode <[EMAIL PROTECTED]> writes:
> In addition, the failure is caused by an accidentally defective
> Debian-specific patch, and is not present upstream!
> debian/patches/ext3-notwork.dpatch contains a completely wrong patch.
>
> + /*
> + * Added by Timshel Knoll <[EMAIL PROTECTED]>, 27/10/02
> + * e2defrag doesn't support ext3 journals (yet)
> + */
> + if(Super.s_feature_compat & ~EXT3_FEATURE_COMPAT_HAS_JOURNAL)
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> + die("ext3 filesystems not (yet) supported");
> +
> The logic here is exactly backwards. It bails out on any feature in the
> "compat" list *except* has_journal. With has_journal, it happily
> continues (even though that's the broken case).
>
> You want the patch to say:
> + if(Super.s_feature_compat & EXT3_FEATURE_COMPAT_HAS_JOURNAL)
> + die("ext3 filesystems not (yet) supported");
Thanks for noticing this. I will add this to my cvs.
As for the dir_index I would be carefull with it. Defrag goes through
the directories and can change the order of dir entries I think. I
don't think dir_index likes it if the order of entries changes.
So while defrag might work you might seem to loose files. This
certainly needs some real live testing before dir_index can be
silently ignored.
MfG
Goswin
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
