Hi Timo

On Sat, Sep 06, 2008 at 04:54:08PM +0300, Timo Juhani Lindfors wrote:
> Apparently on line 1319 of cfb8lineCO.c
> 
> len = abs(new_x2 - new_x1) - 1; /* this routine needs the "-1" */
> 
> sets len to "-1" and later the loop 
> 
> while ((len -= 2) >= 0)
> {
>     body body;
> }
> 
> sets len to "-3" causing
> 
> if (len & 1)
>     body;
> 
> to be run. If I change that to 
> 
> if (len >= 0 && len & 1)
>     body;

Looks like a good soltion to me.

> the code does not crash anymore. Any idea how we could get somebody
> who is familiar with that code to comment if that is the right fix?

No clue actually. I think the code is inherited from Xfree.
I think it is a valid fix if it do not crash anymore.

Do you have a patch file that you can send to me?

Best regards,

// Ola

> 
> 
> 

-- 
 --------------------- Ola Lundqvist ---------------------------
/  [EMAIL PROTECTED]                     Annebergsslingan 37      \
|  [EMAIL PROTECTED]                      654 65 KARLSTAD          |
|  http://inguza.com/                  +46 (0)70-332 1551       |
\  gpg/f.p.: 7090 A92B 18FE 7994 0C36  4FE4 18A1 B1CF 0FE5 3DD9 /
 ---------------------------------------------------------------



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to