On Sun, 2008-08-31 at 02:21 +0200, Frank Lichtenheld wrote: > On Sun, Aug 31, 2008 at 01:37:54AM +0200, Carl Fürstenberg wrote: > > On Sun, Aug 31, 2008 at 01:25, Raphael Geissert > > <[EMAIL PROTECTED]> wrote: > > > Carl Fürstenberg wrote: > > >> the check for embedded prototype javacsript library is prone to many > > >> false positives, as "prototype" is a pretty common word in js-space, > > >> and also that it can be common for JavaScript files, using such library > > >> to be called libfoo-prototype.js etc... > > > > > > Do you mind providing at least one example? > > > > See for example the horde3 package. > > Simply anchoring the regexes, so that they actually need to match a full > filename instead of the end of one should probably take care of most > false positives.
Indeed. This was the case when the check was originally added (hence why the package didn't show up on lintian.d.o's 1.24.2 check) but was inadvertently broken when we moved from a single regular expression to an array of expressions and package names in order to not flag the libraries which ship the "master" copies of the libraries. I've now fixed this in git and horde3 no longer produces any Javascript tags. Adam -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
