tags 493942 + patch thanks Hi there!
On Mon, 11 Aug 2008 14:55:02 +0200, Neil Williams wrote: > On Mon, 2008-08-11 at 16:37 +0800, Wen-Yen Chuang wrote: >> This is not an RC bug. I plan to fix it after release of Lenny. > > It does make the package unusable by all except a particular number of > devices [...] > I'd support making this bug 'serious'. If not 'serious' (to which I agree), it's at least 'important'. >> However, if my sponsor want to see it fixed for Lenny, >> I will be happy to do it. > > As the sponsor of previous uploads, I'd support fixing it for Lenny. ACK. >> I have not tested the patch on Sharp Zaurus yet. >> My SLC-3200 is not on my hand currently. > > Please test on the Sharp Zaurus - I'm at DebConf currently (without my > main upload key) but I can arrange for a sponsored upload either here > or when I get home in a week. I'd say that we should upload the fix ASAP, not only because I'm interested in it for the Openmoko FreeRunner. About the latter, the patched tslib package [1] has been successfully used by different people. FWIW, if needed I can upload either an NMU (patch attached [2]) or I can sponsor here at DebConf. Thx, bye, Gismo / Luca Footnotes: [1] http://pkg-fso.alioth.debian.org/debian/pool/main/x/xf86-input-tslib/ [2] the patch is the less intrusive as possible, relying on quilt to manage the upstream changes --8<---------------cut here---------------start------------->8--- diff -Nru xf86-input-tslib-0.0.4/debian/changelog xf86-input-tslib-0.0.4/debian/changelog --- xf86-input-tslib-0.0.4/debian/changelog 2008-08-09 15:55:44.000000000 +0200 +++ xf86-input-tslib-0.0.4/debian/changelog 2008-08-09 15:55:44.000000000 +0200 @@ -1,3 +1,22 @@ +xf86-input-tslib (0.0.4-5.1) unstable; urgency=low + + * NMU to fix important bug. + + * debian/control: + + depend on quilt to manage Debian patches. + + * debian/patches/series: new file. + * debian/patches/01_fix-wrong-value-range-for-the-axises.diff: + - use touchscreen width and height from the option instead of + hardcoding it in the sources, thanks to Sascha Hauer + <[EMAIL PROTECTED]> (Closes: #493942). + + * debian/rules: + - adapt to quilt, using the debian/xsfbs/xsfbs.mk targets instead + of the usual quilt ones. + + -- Luca Capello <[EMAIL PROTECTED]> Sat, 09 Aug 2008 15:47:12 +0200 + xf86-input-tslib (0.0.4-5) unstable; urgency=low * Add Replaces: xf86-input-tslib to unbreak upgrades diff -Nru xf86-input-tslib-0.0.4/debian/control xf86-input-tslib-0.0.4/debian/control --- xf86-input-tslib-0.0.4/debian/control 2008-08-09 15:55:44.000000000 +0200 +++ xf86-input-tslib-0.0.4/debian/control 2008-08-09 15:55:44.000000000 +0200 @@ -5,7 +5,8 @@ Build-Depends: debhelper (>= 5), xserver-xorg-dev (>= 2:1.4), pkg-config, - libts-dev (>= 1.0-4) + libts-dev (>= 1.0-4), + quilt (>= 0.40) Standards-Version: 3.7.3 Package: xserver-xorg-input-tslib diff -Nru xf86-input-tslib-0.0.4/debian/patches/01_fix-wrong-value-range-for-the-axises.diff xf86-input-tslib-0.0.4/debian/patches/01_fix-wrong-value-range-for-the-axises.diff --- xf86-input-tslib-0.0.4/debian/patches/01_fix-wrong-value-range-for-the-axises.diff 1970-01-01 01:00:00.000000000 +0100 +++ xf86-input-tslib-0.0.4/debian/patches/01_fix-wrong-value-range-for-the-axises.diff 2008-08-09 15:55:44.000000000 +0200 @@ -0,0 +1,42 @@ +Index: src/tslib.c +=================================================================== +--- a/src/tslib.c (revision 28) ++++ b/src/tslib.c (working copy) +@@ -184,9 +184,11 @@ + InputInfoPtr pInfo; + unsigned char map[MAXBUTTONS + 1]; + int i; ++ struct ts_priv *priv; + + ErrorF("%s\n", __FUNCTION__); + pInfo = device->public.devicePrivate; ++ priv = pInfo->private; + + switch (what) { + case DEVICE_INIT: +@@ -222,15 +224,17 @@ + return !Success; + } + +- InitValuatorAxisStruct(device, 0, 0, /* min val */ 1023, /* max val */ +- 1024, /* resolution */ +- 0, /* min_res */ +- 1024); /* max_res */ ++ InitValuatorAxisStruct(device, 0, 0, /* min val */ ++ priv->width - 1, /* max val */ ++ priv->width, /* resolution */ ++ 0, /* min_res */ ++ priv->width); /* max_res */ + +- InitValuatorAxisStruct(device, 1, 0, /* min val */ 1023, /* max val */ +- 1024, /* resolution */ +- 0, /* min_res */ +- 1024); /* max_res */ ++ InitValuatorAxisStruct(device, 1, 0, /* min val */ ++ priv->height - 1,/* max val */ ++ priv->height, /* resolution */ ++ 0, /* min_res */ ++ priv->height); /* max_res */ + + if (InitProximityClassDeviceStruct (device) == FALSE) { + ErrorF ("Unable to allocate EVTouch touchscreen ProximityClassDeviceStruct\n"); diff -Nru xf86-input-tslib-0.0.4/debian/patches/series xf86-input-tslib-0.0.4/debian/patches/series --- xf86-input-tslib-0.0.4/debian/patches/series 1970-01-01 01:00:00.000000000 +0100 +++ xf86-input-tslib-0.0.4/debian/patches/series 2008-08-09 15:55:44.000000000 +0200 @@ -0,0 +1 @@ +01_fix-wrong-value-range-for-the-axises.diff diff -Nru xf86-input-tslib-0.0.4/debian/rules xf86-input-tslib-0.0.4/debian/rules --- xf86-input-tslib-0.0.4/debian/rules 2008-08-09 15:55:44.000000000 +0200 +++ xf86-input-tslib-0.0.4/debian/rules 2008-08-09 15:55:44.000000000 +0200 @@ -3,6 +3,7 @@ # Uncomment this to turn on verbose mode. #export DH_VERBOSE=1 + include debian/xsfbs/xsfbs.mk DEB_HOST_GNU_TYPE ?= $(shell dpkg-architecture -qDEB_HOST_GNU_TYPE) @@ -20,7 +21,7 @@ build: build-stamp -build-stamp: config.status +build-stamp: patch config.status dh_testdir $(MAKE) touch $@ --8<---------------cut here---------------end--------------->8---
pgpGgvTe5s6WM.pgp
Description: PGP signature
