found 476612 21.4a+1-5.4
found 476612 21.4a+1-5.5
tags 476612 + patch
thanks

Sorry for coming a bit late to the party, but today I found out that
this issue is not yet fixed, because ...

On 2008-04-28 12:49 +0200, Nico Golde wrote:

> Hi,
> uploading an NMU to fix this bug, debdiff attached and also
> archived on:
> http://people.debian.org/~nion/nmu-diff/emacs21-21.4a+1-5.3_21.4a+1-5.4.patch
>
> diff -u emacs21-21.4a+1/debian/changelog emacs21-21.4a+1/debian/changelog
> --- emacs21-21.4a+1/debian/changelog
> +++ emacs21-21.4a+1/debian/changelog
> @@ -1,3 +1,11 @@
> +emacs21 (21.4a+1-5.4) unstable; urgency=high
> +
> +  * Non-maintainer upload by the Security Team.
> +  * Fix insecure temporary file creation in vcdiff script leading to
> +    possible symlink attacks (CVE-2008-1694; Closes: #476612).
> +
> + -- Nico Golde <[EMAIL PROTECTED]>  Mon, 28 Apr 2008 12:46:35 +0200
> +
>  emacs21 (21.4a+1-5.3) unstable; urgency=high
>  
>    * Non-maintainer upload.
> diff -u emacs21-21.4a+1/debian/patches/00list 
> emacs21-21.4a+1/debian/patches/00list
> --- emacs21-21.4a+1/debian/patches/00list
> +++ emacs21-21.4a+1/debian/patches/00list

... 00list is the wrong file, it is only used by dpatch while the
package has been switched to quilt. :-(

> @@ -30,0 +31 @@
> +CVE-2008-1694
> only in patch2:
> unchanged:
> --- emacs21-21.4a+1.orig/debian/patches/CVE-2008-1694.diff
> +++ emacs21-21.4a+1/debian/patches/CVE-2008-1694.diff
> @@ -0,0 +1,20 @@
> +diff -Nurad emacs21-21.4a+1.orig/lib-src/vcdiff 
> emacs21-21.4a+1/lib-src/vcdiff
> +--- emacs21-21.4a+1.orig/lib-src/vcdiff      2008-04-28 12:44:53.000000000 
> +0200
> ++++ emacs21-21.4a+1/lib-src/vcdiff   2008-04-28 12:45:46.000000000 +0200
> +@@ -86,14 +86,14 @@
> +     case $f in
> +     s.* | */s.*)
> +             if
> +-                    rev1=/tmp/geta$$
> ++                    rev1=$(mktemp /tmp/geta.XXXXXXXX)
> +                     get -s -p -k $sid1 "$f" > $rev1 &&
> +                     case $sid2 in
> +                     '')
> +                             workfile=`expr " /$f" : '.*/s.\(.*\)'`
> +                             ;;
> +                     *)
> +-                            rev2=/tmp/getb$$
> ++                            rev2=$(mktemp /tmp/getb.XXXXXXXX)
> +                             get -s -p -k $sid2 "$f" > $rev2
> +                             workfile=$rev2
> +                     esac

A debdiff which adds the patch to the series file and deletes the
redundant and confusing 00list file follows:

--8<---------------cut here---------------start------------->8---
diff -u emacs21-21.4a+1/debian/changelog emacs21-21.4a+1/debian/changelog
--- emacs21-21.4a+1/debian/changelog
+++ emacs21-21.4a+1/debian/changelog
@@ -1,3 +1,13 @@
+emacs21 (21.4a+1-5.6) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * debian/patches/series: Add CVE-2008-1694.diff
+    (CVE-2008-1694; really Closes: #476612).
+  * debian/patches/00list: Remove to ensure that patches are added to
+    debian/patches/series instead.
+
+ -- Sven Joachim <[EMAIL PROTECTED]>  Tue, 05 Aug 2008 17:25:20 +0200
+
 emacs21 (21.4a+1-5.5) unstable; urgency=medium
 
   * Non-maintainer upload.
diff -u emacs21-21.4a+1/debian/patches/series 
emacs21-21.4a+1/debian/patches/series
--- emacs21-21.4a+1/debian/patches/series
+++ emacs21-21.4a+1/debian/patches/series
@@ -34,6 +34,7 @@
 ldapsearch-output.diff
 CVE-2007-6109.diff
 CVE-2007-2833.diff
+CVE-2008-1694.diff
 fix-dumping.diff
 arch-kfreebsd.diff
 CVE-2008-2142.diff
reverted:
--- emacs21-21.4a+1/debian/patches/00list
+++ emacs21-21.4a+1.orig/debian/patches/00list
@@ -1,31 +0,0 @@
-autoconf-updates
-misc-unseparated
-arch-hppa
-arch-mipsel
-arch-s390
-fix-batch-mode-signal-handling
-browse-url
-bzero-and-have-stdlib
-detect-coding-iso2022
-movemail-mailspool
-version-mention-debian
-hurd-libio-glibc
-battery-acpi-support
-scroll-margin
-save-buffer
-emacsclient-alternate-editor
-startup-auto-save-file-name-transforms
-python-completion-ignored-extensions
-xfree86-4.3-modifiers
-coding-region-leak
-remote-files-permissions
-pcl-cvs-format
-arch-amd64
-#arch-ppc64
-multibyte-char-key-modifiers
-xorg-altgr-fix
-whitespace-readonly-infloop
-fix-x-vs-no-x-diffs
-autofiles
-CVE-2007-2833
-CVE-2008-1694
--8<---------------cut here---------------end--------------->8---

Cheers,
       Sven




-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to