Thomas Goirand wrote: > Your patch is good, however, your configuration file has everything > disabled by default. I do NOT want to do things this way, I think it > should be set to be run with all the full options as much as possible. > So why did you comment out all things in it? Is there any reason?
Thanks for the response, and I'm glad you like the patch. Unless I messed something up, the file and patch I sent could be deployed without affecting the current configuration of dkimproxy. Having the variables in the config file commented out is the same as uncommenting them (with the defaults I provided). The defaults are all copied from the initial values that are still set in /etc/init.d/dkimproxy. Anything in /etc/default/dkimproxy would override those values. My idea was that a user would uncomment and alter any values he or she wants to be different from the default, and it would be obvious that any commented values remain set to their defaults. Actually, the above paragraph is true for all but DOMAIN, which currently has a few lines of parsing that wouldn't cleanly fit on a single line, and I don't know if moving that to /etc/default/dkimproxy would be a good idea. Anyway, that said, I don't have any strong opinions as to whether my approach is The Right Way To Do It. I think it's a little bit better, but maybe it's only better for people who think the way I do. I'm happy to defer to your opinion on the matter. If anything I've written is unclear, that's because it's way past my bedtime, and I can clarify tomorrow. -Corey -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
