Hi Petr,

Thanks for the note and the patch.  I'm forwarding it on to
upstream.


On Mon, Jul 28, 2008 at 10:45:04PM +0200, Petr Salinger wrote:

> The FreeBSD kernel uses the same value for POLL_ERR and POLL_HUP,
> see http://www.freebsd.org/cgi/cvsweb.cgi/src/sys/sys/signal.h

I have to say, my first reaction is to ask whether this
is deliberate or not.  The code in question (from sys/signal.h)
reads:

/* codes for SIGPOLL */
#define POLL_IN         1       /* Data input available                 */
#define POLL_OUT        2       /* Output buffers available             */
#define POLL_MSG        3       /* Input message available              */
#define POLL_ERR        4       /* I/O Error                            */
#define POLL_PRI        5       /* High priority input available        */
#define POLL_HUP        4       /* Device disconnected                  */


If it were really meant to duplicate POLL_ERR, then
arguably it should be written 

  #define POLL_HUP POLL_ERR



Are you certain that POLL_HUP isn't meant to be "6"?

Thanks,
-Steve

Attachment: signature.asc
Description: Digital signature

Reply via email to