# Fixed in Git commit 32224dc903b79c22fd4c7f8c980310a6ee30c338. # See http://git.tokkee.org/?p=pkg-tig.git. tags 481828 + pending thanks
Hi,
On Wed, Jul 23, 2008 at 12:30:22PM +0100, Bruce Stephens wrote:
> The code is indeed doing popen("git config --list", ...).
>
> Code looks OK to me, and after a rebuild of the package, works fine.
> So I've no idea what happened to the official package.
Okay, here's the relevant part of configure.ac which caused this
problem:
AC_CHECK_PROGS(GIT_CONFIG, [git-config git-repo-config])
if test "${ac_cv_prog_GIT_CONFIG}" = ""; then
AC_CHECK_PROGS(GIT, [git])
GIT_CONFIG="${ac_cv_prog_GIT} config"
fi
So, if neither git-config / git-repo-config nor git was available at
build time, $GIT_CONFIG would equal " config" which was then passed to
popen in tig.c as popen(GIT_CONFIG " --list", ...), thus expanding to
" config --list".
This has been fixed by adding git-core to the build dependencies. I will
upload a new package tomorrow, so it should still hit Lenny.
Cheers,
Sebastian
--
Sebastian "tokkee" Harl +++ GnuPG-ID: 0x8501C7FC +++ http://tokkee.org/
Those who would give up Essential Liberty to purchase a little Temporary
Safety, deserve neither Liberty nor Safety. -- Benjamin Franklin
signature.asc
Description: Digital signature
