Package: websvn
Version: 1.61-20
Severity: normal
Tags: patch

Hello,

Browsing a path that has a ~ in it doesn't work with the version of
websvn in etch, because the ~ in the path gets escaped with a backslash.
I suspect this is the case for other special characters as well, since
the issue is that websvn filters the path through the escapeshellcmd()
function.

I have attached a patch that disables this filtering.  (Upstream did
this as well, in r374, so this problem doesn't exist in the version in
unstable.  It would be nice to see this in an etch update, though.)

Thanks,
John
This patch fixes the problem where paths with '~' in them cannot be displayed,
because PHP would try to escape the '~' with a '\'.  See also r374 in the
upstream repository.
Index: websvn-1.61/include/setup.inc
===================================================================
--- websvn-1.61.orig/include/setup.inc	2008-07-22 16:14:42.000000000 -0600
+++ websvn-1.61/include/setup.inc	2008-07-22 16:15:12.000000000 -0600
@@ -291,7 +291,6 @@
 else
    $path = html_entity_decode(@$_REQUEST["path"], ENT_COMPAT, $config->outputEnc);
 
-$path = escapeshellcmd($path);
 $rev = (int)@$_REQUEST["rev"];
 $showchanged = (@$_REQUEST["sc"] == 1)?1:0;
 

Reply via email to