Package: kaffeine-mozilla
Version: 0.4.3.1-1
Tags: patch

At the moment, to get debug output out of the kaffeine-mozilla plugin,
one need to recompile it after setting the LOG define.  After finding
out how useful this debug output was when debugging and solving the
issue documented in #490723, I believe it should be easier to enable
it.

Here is a patch to change it from a compile time flag to a run time
flag, enabled by setting the environment variable
DEBUG_KAFFEINE_MOZILLA.

Please include it in a future version of kaffeine-mozilla.

--- kaffeine-mozilla-0.4.3.1.dfsg.orig/src/plugin.c
+++ kaffeine-mozilla-0.4.3.1.dfsg/src/plugin.c
@@ -73,12 +73,6 @@
 #include "plugin.h"


-/* define LOG to write debug messages to /tmp/kaffeine_plugin.log */
-/*
-#define LOG
-*/
-
-
 #define STATUS_STR_SIZE 1024

 static char IsInitialised=0;
@@ -115,7 +109,12 @@

 static void xprintf (const char *format, ...) {

-#ifdef LOG
+  static int debug_log = -1;
+  if (-1 == debug_log)
+    debug_log = NULL != getenv("DEBUG_KAFFEINE_MOZILLA");
+  if (!debug_log)
+    return;
+
   static FILE *log_fd=NULL;

   va_list argp;
@@ -138,7 +137,6 @@
   if (log_fd) vfprintf (log_fd, format, argp);

   va_end (argp);
-#endif
 }

 char *NPP_GetMIMEDescription(void) {

Happy hacking,
-- 
Petter Reinholdtsen



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to