On Sun, Jul 13, 2008 at 06:53:25PM +0930, Kevin Shanahan wrote: > Package: e2fsprogs > Version: 1.41.0-1
Thanks for reporting this bug. I will shortly be releasing a fixed e2fsprogs with this patch. - Ted >From 4729455f0a68f2fa0a83ec8460d1d4bccba9dcfa Mon Sep 17 00:00:00 2001 From: Theodore Ts'o <[EMAIL PROTECTED]> Date: Sun, 13 Jul 2008 19:03:59 -0400 Subject: [PATCH] libext2fs: Don't check the group checksum when !GDT_CSUM ext2fs_group_desc_csum_verify() is always checking the bg_checksum (to make sure it is zero) even when the GDT_CSUM feature is not present. This is normally OK, but apparently there are filesystems in the wild where this field has not be initialized to zero. Addresses-Debian-Bug: #490637 Signed-off-by: "Theodore Ts'o" <[EMAIL PROTECTED]> --- lib/ext2fs/csum.c | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/ext2fs/csum.c b/lib/ext2fs/csum.c index ce1508e..6a49d8f 100644 --- a/lib/ext2fs/csum.c +++ b/lib/ext2fs/csum.c @@ -60,8 +60,10 @@ STATIC __u16 ext2fs_group_desc_csum(ext2_filsys fs, dgrp_t group) int ext2fs_group_desc_csum_verify(ext2_filsys fs, dgrp_t group) { - if (fs->group_desc[group].bg_checksum != - ext2fs_group_desc_csum(fs, group)) + if (EXT2_HAS_RO_COMPAT_FEATURE(fs->super, + EXT4_FEATURE_RO_COMPAT_GDT_CSUM) && + (fs->group_desc[group].bg_checksum != + ext2fs_group_desc_csum(fs, group))) return 0; return 1; -- 1.5.6.1.205.ge2c7.dirty -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]