Steve McIntyre wrote:
On Sat, Jul 05, 2008 at 08:30:47PM +0200, Samuel Colin wrote:
Package: genisoimage
Version: 9:1.1.8-1
Followup-For: Bug #488482
Hi,
Hi,
it's-a-me again, I found some courage and tried to look for what specific
change might have introduced the problem. You will find the attached patch
which seems to solve it. A few more details:
- I tested the patch by comparing versions 1.1.7 and 1.1.8 with the patch
with "-v -v" parameter and both versions compiled with -DDEBUG for
genisoimage: Except for the version number and the "X% done, estimate
finish...", there is no difference
- The ISO image was produced with -R (not -r or -xa, thus they might need
testing too). By mounting it with "-o loop" and exploring the deep
directories I could access the files
- I have no clue why this patch works except that it was among "default"
value settings and it made my coder-sense tingle.
diff --git a/genisoimage/tree.c b/genisoimage/tree.c
index a11098a..7805888 100644
--- a/genisoimage/tree.c
+++ b/genisoimage/tree.c
@@ -1994,7 +1994,7 @@ insert_file_entry(struct directory *this_dir, char
*whole_path,
s_entry1->filedir = this_dir;
statbuf.st_size = (off_t)0;
-// statbuf.st_mode &= 0777;
+ statbuf.st_mode &= 0777;
set_733((char *) s_entry->isorec.size, 0);
s_entry->realsize=0;
s_entry->size = 0;
Thanks very much for the analysis here - it looks very useful. The
change that went in in the last release was from a patch by Roman to
preserve directory permissions. Maybe he can comment on the effects
here...
Hi.
I'm sorry for introducing this bug. When I was porting the patch I do
some changes and forgot to turn back this change.
begin:vcard
fn:Roman Rakus
n:Rakus;Roman
org:Red Hat;BaseOS
adr:;;;Brno;;;Czech Republic
email;internet:[EMAIL PROTECTED]
title:Associate software engineer
tel;cell:+420 774 891 861
x-mozilla-html:FALSE
version:2.1
end:vcard
